From 1dc42a2cb16cf2530dafa3b0eaafe3dbcc07f90f Mon Sep 17 00:00:00 2001 From: Jeremy Ninnes Date: Fri, 21 Jul 2023 15:24:24 +0930 Subject: [PATCH 1/2] Update to use Jenkins BOM for dependencies --- pom.xml | 69 ++++++++++++++++++++++----------------------------------- 1 file changed, 26 insertions(+), 43 deletions(-) diff --git a/pom.xml b/pom.xml index d35773f..1225f7d 100644 --- a/pom.xml +++ b/pom.xml @@ -5,8 +5,8 @@ org.jenkins-ci.plugins plugin - - 1.609.1 + + 4.46 @@ -15,11 +15,11 @@ hpi - 2.5.1 - 1.112 - 2.6 2.10 - 1.11 + 2.80 + + 2.387.3 + 8 Bitbucket Build Status Notifier Plugin @@ -74,77 +74,63 @@ + + + + io.jenkins.tools.bom + bom-2.387.x + 2244.vd60654536b_96 + import + pom + + + + org.jenkins-ci.plugins git - 2.4.0 org.jenkins-ci.plugins mercurial - 1.54 + 1260.vdfb_723cdcc81 org.jenkins-ci.plugins.workflow workflow-step-api - ${workflow.version} - - - org.jenkins-ci.plugins.workflow - workflow-cps - ${workflow.version} + + org.jenkins-ci.plugins.workflow workflow-job - ${workflow.version} - - - org.jenkins-ci.plugins.workflow - workflow-aggregator - ${workflow.version} - test - - - org.jenkins-ci.plugins.workflow - workflow-aggregator - tests - ${workflow.version} - test - - - org.jenkins-ci.plugins.workflow - workflow-step-api - tests - ${workflow.version} - test + + + com.google.code.gson gson - 2.2.2 + 2.10.1 compile org.scribe scribe - 1.3.3 + 1.3.7 org.jenkins-ci.plugins credentials - 1.22 org.jenkins-ci.plugins junit - 1.0 org.jenkins-ci.plugins display-url-api - 0.4 @@ -153,7 +139,6 @@ org.jenkins-ci.tools maven-hpi-plugin - ${maven-hpi-plugin.version} true @@ -166,7 +151,6 @@ org.apache.maven.plugins maven-release-plugin - ${maven-release-plugin.version} deploy @@ -175,7 +159,6 @@ org.apache.maven.plugins maven-deploy-plugin - ${maven-deploy-plugin.version} org.apache.maven.wagon From 561e577a63f2f945109150440739ef755a63ba5f Mon Sep 17 00:00:00 2001 From: Jeremy Ninnes Date: Fri, 21 Jul 2023 15:25:02 +0930 Subject: [PATCH 2/2] Fix JENKINS-40456 - use current build to find SCM values --- .../plugins/bitbucket/BitbucketBuildStatusHelper.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/jenkinsci/plugins/bitbucket/BitbucketBuildStatusHelper.java b/src/main/java/org/jenkinsci/plugins/bitbucket/BitbucketBuildStatusHelper.java index 16c1d8b..b2d58cf 100644 --- a/src/main/java/org/jenkinsci/plugins/bitbucket/BitbucketBuildStatusHelper.java +++ b/src/main/java/org/jenkinsci/plugins/bitbucket/BitbucketBuildStatusHelper.java @@ -58,6 +58,7 @@ import org.jenkinsci.plugins.bitbucket.validator.BitbucketHostValidator; import org.jenkinsci.plugins.displayurlapi.DisplayURLProvider; import org.jenkinsci.plugins.workflow.job.WorkflowJob; +import org.jenkinsci.plugins.workflow.job.WorkflowRun; import org.scribe.model.*; class BitbucketBuildStatusHelper { @@ -134,7 +135,13 @@ public static List createBuildStatusResources(fina Job project = build.getParent(); List buildStatusResources = new ArrayList(); - if (project instanceof WorkflowJob) { + if (build instanceof WorkflowRun) { + Collection scms = ((WorkflowRun)build).getSCMs(); + + for (SCM scm : scms) { + buildStatusResources.addAll(createBuildStatusResources(scm, build)); + } + } else if (project instanceof WorkflowJob) { Collection scms = ((WorkflowJob)project).getSCMs(); for (SCM scm : scms) {