Test Kubernetes Credentials Provider plugin update #5088
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-weekly (jenkinsci#5078)" Tests fail for kubernetes credentials provider plugin and possible others as a result of the API plugin upgrade. jenkinsci#5076 (comment) This reverts commit 7b9de21.
12 tasks
MarkEWaite
added a commit
to MarkEWaite/bitbucket-branch-source-plugin
that referenced
this pull request
May 24, 2025
…tibility Blue Ocean Bitbucket plugin depends on this plugin and uses the BitbucketEndpointConfiguration.normalizeServerUrl method. Rather than require a new release of Blue Ocean, let's retain compatibility by restoring that method and marking it as deprecated. Detected in: * jenkinsci/bom#5076 * jenkinsci/bom#5088 Testing done: mvn -Dtest=BitbucketSCMNavigatorTest,BitbucketEndpointConfigurationTest,BitbucketServerEndpointTest,BitbucketSCMNavigatorTest clean verify
6 tasks
Restores the BitbucketEndpointConfiguration.normalizeServerUrl method for compatibility with the Blue Ocean Bitbucket plugin.
6 tasks
Jackson 2 API 2.19.0 seems to cause class loading issues in the kubernetes credentials provider tests. Pull request has been submitted that shows the issue: * jenkinsci/kubernetes-credentials-provider-plugin#115
MarkEWaite
changed the title
krisstern
approved these changes
May 26, 2025
|
I've requested a review from @basil because he may have better insights into a solution. |
MarkEWaite
added a commit
to MarkEWaite/kubernetes-credentials-provider-plugin
that referenced
this pull request
May 26, 2025
Workaround to prevent plugin BOM tests from failing with Jackson 2 API 2.19.0. jenkinsci/bom#5076 (comment) provides some additional details. Incremental build will be tested with: * jenkinsci/bom#5088 Does not alter the runtime dependencies of the plugin, since the dependencies that have been added are test dependencies. Confirmed by comparing the MANIFEST.MF entries from the most recent plugin release and this change.
Confirmed to pass tests with: LINE=weekly PLUGINS=kubernetes-credentials-provider TEST=KubernetesCredentialsProviderTest#startWatchingForSecrets bash ./local-test.sh
MarkEWaite
changed the title
|
I vaguely recall class loading issues with Jackson but I have no recollection of what they were. |
|
Resolved by the release of Kubernetes credentials provider plugin release 1.281.v331e3f5a_05a_9. That includes a dependency on openstack-cloud-plugin 1456.v1c7380506a_ed that removes its incorrect inclusion of the Jackson API library inside the plugin HPI file. Requires test exclusions until the 2.492.x line is dropped. Exclusion added in: Issue created to track the eventual removal of those exclusions: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Kubernetes Credentials Provider plugin update
Tests fail for kubernetes credentials provider plugin as a result of the Jackson 2 API plugin upgrade.
#5076 (comment)
Issue opened to track the future removal of the exclusion:
Testing done
Found a workaround that can be released in the Kubernetes Credentials Provider plugin:
Submitter checklist