Open
Conversation
|
Is there any consideration to withhold this PR ? |
Contributor
Author
|
@aamsur-mkt I run into some problems with this PR, so need to check what is broken. |
DricomDragon
reviewed
Jan 5, 2020
Comment on lines
+109
to
+110
| if (!"push".equals(event) && !"release".equals(event)) { | ||
| result.setStatus(403, "Only push or release events are accepted."); |
There was a problem hiding this comment.
Can the create event be added as well ?
e.g.
if (!"push".equals(event) && !"release".equals(event) && !"create".equals(event)) {
result.setStatus(403, "Only push, release or create events are accepted.");
There was a problem hiding this comment.
Can the pull_request event be added as well ?
e.g.
if (!"push".equals(event) && !"release".equals(event) && !"create".equals(event) && !"pull_request".equals(event)) {
result.setStatus(403, "Only push, release, create or pull_request events are accepted.");
Contributor
Author
There was a problem hiding this comment.
Same here as the above comment. Adding other events breaks things at the moment. Need to investigate how to fix this.
There was a problem hiding this comment.
@sanderv32 very interested in this work being completed and merged. Is there something I can contribute to help?
Contributor
Author
There was a problem hiding this comment.
The whole thing broke down with this changes. Haven't looked for a long time at this change, but if you want to test please do so.
TheHardGamer
added a commit
to TheHardGamer/gogs-webhook-plugin
that referenced
this pull request
Aug 31, 2022
Release events support was partially added in jenkinsci#62 but since its payload doesn't contain certain things, it was failing with return status being {"result":"ERROR","message":"net.sf.json.JSONException: JSONObject[\"commits\"] is not a JSONArray."}
TheHardGamer
added a commit
to TheHardGamer/gogs-webhook-plugin
that referenced
this pull request
Aug 31, 2022
Release events support was partially added in jenkinsci#62 but since its payload doesn't contain certain things, it was failing with return status being {"result":"ERROR","message":"net.sf.json.JSONException: JSONObject[\"commits\"] is not a JSONArray."}
TheHardGamer
added a commit
to TheHardGamer/gogs-webhook-plugin
that referenced
this pull request
Aug 31, 2022
Release events support was partially added in jenkinsci#62 but since its payload doesn't contain certain things, it was failing with return status being {"result":"ERROR","message":"net.sf.json.JSONException: JSONObject[\"commits\"] is not a JSONArray."}
TheHardGamer
added a commit
to TheHardGamer/gogs-webhook-plugin
that referenced
this pull request
Aug 31, 2022
Release events support was partially added in jenkinsci#62 but since its payload doesn't contain certain things, it was failing with return status being {"result":"ERROR","message":"net.sf.json.JSONException: JSONObject[\"commits\"] is not a JSONArray."}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allow to also use the Gogs
releaseevent.