Resolved mismatch stubbings in SendStepTest.java

[ARMS2025]

Description

I analyzed the test doubles (mocks) in the test code of the project. In my analysis of the project, I observed that

In the test testWithEmptyHubotURLThrowsAbortException:

• The get method for the envVarsMock object:
  i) is stubbed in the setup method with argument "BUILD_URL"
  ii) during test execution the method is actually called with argument "HUBOT_FAIL_ON_ERROR", resulting in a mismatch stubbing

In the test testWithEmptyRoomThrowsAbortException:

• The get method for the envVarsMock object:
  i) is stubbed in the setup method with argument "HUBOT_URL"
  ii) is also stubbed in the setup method with argument "BUILD_URL"
  iii) during test execution the method is actually called with argument "HUBOT_DEFAULT_ROOM", resulting in a mismatch stubbing
  iv) during test execution the method is actually called with argument "HUBOT_FAIL_ON_ERROR", resulting in another mismatch stubbing

In the tests testErrorMessageSend and testSuccessfulMessageSend:

• The get method for the envVarsMock object:
  i) is stubbed in the setup method with argument "BUILD_URL"
  ii) during test execution the method is actually called with argument "HUBOT_FAIL_ON_ERROR", resulting in a mismatch stubbing
  iii) during test execution the method is actually called with argument "CHANGE_AUTHOR", resulting in another mismatch stubbing

In the test testFailOnErrorFalseDoesNotThrowsAbortException:

• The get method for the envVarsMock object:
  i) is stubbed in the setup method with argument "BUILD_URL"
  ii) during test execution the method is actually called with argument "HUBOT_DEFAULT_ROOM", resulting in a mismatch stubbing

In general, a mismatched stubbing occurs when a method is stubbed with specific arguments in a test but later invoked with different arguments in the code. Mockito recommends addressing this type of issue (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org.mockito/org/mockito/exceptions/misusing/PotentialStubbingProblem.html).

I propose a solution below to resolve the mismatch stubbing. Happy to modify the pull request based on your feedback.

Submitter checklist

• Link to JIRA ticket in description, if appropriate. (Not applicable)
• Change is code complete and matches issue description
• Appropriate unit or acceptance tests or explanation to why this change has no tests. (Not applicable)
• Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

• Run the changes and verified the change matches the issue description
• Reviewed the code
• Verified that the appropriate tests have been written or valid explanation given