-
-
Notifications
You must be signed in to change notification settings - Fork 136
Pull Request: Fix Blade Container Binding and blade.compiler Resolution for Illuminate\View v10,v11+ #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Support illuminate/view 11.0 above and fix blade.compiler does not exist. Support php 8.4
…ally 10 and above. Update README.md to include BladeContainer in instantiation example
…onventions; add pint.json configuration.
I have successfully resolved the issues related to the blade.compiler error that occurs in certain versions of the illuminate/view package, specifically versions 10, 11, and 12. Additionally, I have fixed the Blade Container instance to ensure proper functionality. These changes ensure compatibility and stability across the mentioned versions, addressing potential errors and improving the overall reliability of the codebase. The fixes are now ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I was checking out the changes needed to adapt to newer versions of upstream, and I noticed a couple things I quite don't understand how they fit in this PR. Thanks!
.phpunit.cache/ | ||
.phpunit.result.cache | ||
.phpunit.result.cache | ||
.qodo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of .qodo
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's just a folder where my qodo ai extension automatically generate in my project so i put it in gitignore file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You pushed an empty file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that just Laravel pint auto-formated a php file.
Summary
This pull request addresses two key issues to ensure compatibility with Illuminate\View v11 and above, and improve the reliability of the Jessenger Blade integration:
Fixes improper container binding for Jessenger Blade
The Blade compiler instance was not being properly resolved from the container, leading to inconsistencies or runtime errors in some contexts.
Fixes missing blade.compiler binding in Illuminate\View v11+
Since Laravel 11 removed or refactored the blade.compiler binding, this fix resolves the compiler using BladeCompiler::class directly for versions v11 and above.
Updated the README
Clarified setup instructions and added notes on Laravel 11+ compatibility to guide developers during installation and configuration.
Changes Made
Testing