Skip to content

Conversation

rcalicdan
Copy link

Summary
This pull request addresses two key issues to ensure compatibility with Illuminate\View v11 and above, and improve the reliability of the Jessenger Blade integration:

Fixes improper container binding for Jessenger Blade
The Blade compiler instance was not being properly resolved from the container, leading to inconsistencies or runtime errors in some contexts.

Fixes missing blade.compiler binding in Illuminate\View v11+
Since Laravel 11 removed or refactored the blade.compiler binding, this fix resolves the compiler using BladeCompiler::class directly for versions v11 and above.

Updated the README
Clarified setup instructions and added notes on Laravel 11+ compatibility to guide developers during installation and configuration.

Changes Made

  1. Updated service provider to resolve BladeCompiler::class conditionally based on the Laravel version.
  2. Maintained backward compatibility with Laravel 10 and earlier by preserving legacy binding logic.
  3. Refactored container binding to ensure the Blade compiler is properly injected.
  4. Improved README with clearer installation instructions notes.

Testing

  • Confirmed compatibility with Laravel 10 (Illuminate\View v10).
  • Verified fixes work as expected in Laravel 11 (Illuminate\View v11).
  • All Blade rendering paths now function correctly across supported versions.

rcalicdan and others added 5 commits April 20, 2025 21:22
Support illuminate/view 11.0 above and fix blade.compiler does not exist.

Support php 8.4
…ally 10 and above. Update README.md to include BladeContainer in instantiation example
@rcalicdan
Copy link
Author

I have successfully resolved the issues related to the blade.compiler error that occurs in certain versions of the illuminate/view package, specifically versions 10, 11, and 12. Additionally, I have fixed the Blade Container instance to ensure proper functionality.

These changes ensure compatibility and stability across the mentioned versions, addressing potential errors and improving the overall reliability of the codebase. The fixes are now ready to be merged.

Copy link
Author

@rcalicdan rcalicdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks..

Copy link

@emorales-ajpf emorales-ajpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I was checking out the changes needed to adapt to newer versions of upstream, and I noticed a couple things I quite don't understand how they fit in this PR. Thanks!

.phpunit.cache/
.phpunit.result.cache
.phpunit.result.cache
.qodo

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of .qodo here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just a folder where my qodo ai extension automatically generate in my project so i put it in gitignore file.

php

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You pushed an empty file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that just Laravel pint auto-formated a php file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants