Skip to content

Conversation

@vandrade-git
Copy link
Contributor

@vandrade-git vandrade-git commented Jan 20, 2025

This library has ALB integration but current TypeScript types do not reflect this.

For example the API#run method does not accept an ALBEvent type meaning that if someone wants to be extremely correct the fix is something like the following:

async function handler(event: ALBEvent, context: Context): Promise<any> {
  return api.run(event as unknown as APIGatewayProxyEvent, context);
}

This PR aims to fix this.

Copy link
Collaborator

@naorpeled naorpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you for your contribution :)

@naorpeled naorpeled merged commit 1f9c70c into jeremydaly:main Jan 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants