Skip to content

Fix cmake #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix cmake #3

merged 1 commit into from
Dec 5, 2024

Conversation

ByteHamster
Copy link
Contributor

@ByteHamster ByteHamster commented Dec 5, 2024 •
edited
Loading

  • Using PROJECT_NAME was misleading because the add_subdirectory call below that changed the project name.
  • Only add testing and additional targets if this is the main project. Dependencies using this project do not need access to test_parse.cpp

@ByteHamster
Fix cmake
e5a1b8a 
- Using `PROJECT_NAME` was misleading because the ´add_subdirectory`
  call below that changed the project name.
- Only add testing and additional targets if this is the main project.
  Dependencies using this project do not need access to `test_parse.cpp`
@jermp jermp merged commit 6262493 into jermp:master Dec 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ByteHamster @jermp