Skip to content

Commit a753e62

Browse files
suzakujessebye
suzaku
authored and
jessebye
committed
chore: Fix spell checking config (argoproj-labs#577)
Signed-off-by: satoru <satorulogic@gmail.com> Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> docs: Fixed typo (argoproj-labs#589) Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> chore: Preallocate space for slices with known size (argoproj-labs#575) Signed-off-by: satoru <satorulogic@gmail.com> Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> ci: Fix codegen and update kustomize to post-2.0 (argoproj-labs#590) * ci: Fix codegen Signed-off-by: jannfis <jann@mistrust.net> * Fix tar call Signed-off-by: jannfis <jann@mistrust.net> --------- Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> feat: Respect original parameter overrides with git write-back (argoproj-labs#573) * Fix original override not respected Signed-off-by: KS. Yim <ks.yim@linecorp.com> * Add writeOverrides unittest Signed-off-by: KS. Yim <ks.yim@linecorp.com> * Add helm override commit test Signed-off-by: KS. Yim <ks.yim@linecorp.com> * lint Signed-off-by: KS. Yim <ks.yim@linecorp.com> * fix shadowed err Signed-off-by: KS. Yim <ks.yim@linecorp.com> --------- Signed-off-by: KS. Yim <ks.yim@linecorp.com> Co-authored-by: KS. Yim <ks.yim@linecorp.com> Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> chore: Update to newer argocd version for better API compatibility (argoproj-labs#594) * fix: update go mods to use newer argocd app definition Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> * fix deps and tests Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> * fix spelling Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> --------- Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> chore(deps): upgrade dependencies for fix vulnerabilities (argoproj-labs#599) Signed-off-by: Viacheslav Sychov <viacheslav.sychov@gmail.com> Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> fix: tighten securityContext to comply with restricted PSS (argoproj-labs#600) makes argocd-image-updater compatible with restricted Pod Security Standard Signed-off-by: Takeo Sawada <myc.monad@gmail.com> Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> feat: Add possibility to specify write-back GIT repository as annotation (argoproj-labs#424) * Add possibility to specify write-back GIT repository as annotation. Signed-off-by: flozzone <flozzone@gmail.com> * Update golangci-lint to 1.52.2. Signed-off-by: flozzone <flozzone@gmail.com> * Replace deprecated golangci linters with 'unused' linter. Signed-off-by: flozzone <flozzone@gmail.com> * Fix Goimport issues. Signed-off-by: flozzone <flozzone@gmail.com> --------- Signed-off-by: flozzone <flozzone@gmail.com> Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> fix: support ocischema.DeserializedImageIndex in registry client Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> fix test Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> fix: update go mods to use newer argocd app definition Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> fix deps and tests Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> merge master Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> fix go mods Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> refactor: use shared function to reduce duplication Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> fix: update go mods to use newer argocd app definition Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> fix deps and tests Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> merge master Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> fix go mods Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> Fix after rebase Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> chore: Fix spell checking config (argoproj-labs#577) Signed-off-by: satoru <satorulogic@gmail.com> docs: Fixed typo (argoproj-labs#589) chore: Preallocate space for slices with known size (argoproj-labs#575) Signed-off-by: satoru <satorulogic@gmail.com> ci: Fix codegen and update kustomize to post-2.0 (argoproj-labs#590) * ci: Fix codegen Signed-off-by: jannfis <jann@mistrust.net> * Fix tar call Signed-off-by: jannfis <jann@mistrust.net> --------- Signed-off-by: jannfis <jann@mistrust.net> feat: Respect original parameter overrides with git write-back (argoproj-labs#573) * Fix original override not respected Signed-off-by: KS. Yim <ks.yim@linecorp.com> * Add writeOverrides unittest Signed-off-by: KS. Yim <ks.yim@linecorp.com> * Add helm override commit test Signed-off-by: KS. Yim <ks.yim@linecorp.com> * lint Signed-off-by: KS. Yim <ks.yim@linecorp.com> * fix shadowed err Signed-off-by: KS. Yim <ks.yim@linecorp.com> --------- Signed-off-by: KS. Yim <ks.yim@linecorp.com> Co-authored-by: KS. Yim <ks.yim@linecorp.com> chore: Update to newer argocd version for better API compatibility (argoproj-labs#594) * fix: update go mods to use newer argocd app definition Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> * fix deps and tests Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> * fix spelling Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> --------- Signed-off-by: Jesse Bye <8467862+jessebye@users.noreply.github.com> chore(deps): upgrade dependencies for fix vulnerabilities (argoproj-labs#599) Signed-off-by: Viacheslav Sychov <viacheslav.sychov@gmail.com> fix: tighten securityContext to comply with restricted PSS (argoproj-labs#600) makes argocd-image-updater compatible with restricted Pod Security Standard Signed-off-by: Takeo Sawada <myc.monad@gmail.com>
1 parent 568e6b9 commit a753e62

26 files changed

+1603
-788
lines changed

‎.github/actions/spelling/expect.txt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,26 +5,18 @@ bacd
55
CVE
66
credref
77
DEBU
8-
DEBU
98
dockerhub
109
eec
1110
fbd
1211
ffb
1312
gitlab
1413
jfrog
15-
JFrog
1614
mep
17-
mypass
1815
myregistry
19-
myuser
20-
otherapp
2116
repocreds
2217
rollbacked
2318
someimage
2419
somerepo
2520
ssw
26-
wildcard
2721
wildcards
28-
wohoo
2922
yyyy
30-
YYYY

‎.github/workflows/ci-tests.yaml

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,17 @@ jobs:
3535
- name: Install Kustomize v2
3636
run: |
3737
set -xo pipefail
38-
KUSTOMIZE_VERSION=2.0.2
39-
URL="https://github.com/kubernetes-sigs/kustomize/releases/download/v${KUSTOMIZE_VERSION}/kustomize_${KUSTOMIZE_VERSION}_linux_amd64"
40-
BINNAME=kustomize2
41-
curl -sLf --retry 3 -o /tmp/kustomize2 "$URL"
42-
sudo mv /tmp/kustomize2 /usr/local/bin/kustomize2
43-
chmod +x /usr/local/bin/kustomize2
38+
URL="https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv5.1.0/kustomize_v5.1.0_linux_amd64.tar.gz"
39+
BINNAME=kustomize
40+
curl -sLf --retry 3 -o /tmp/kustomize.tar.gz "$URL"
41+
chksum=$(sha256sum /tmp/kustomize.tar.gz | awk '{ print $1; }')
42+
if test "${chksum}" != "52f4cf1ba34d38fd55a9bef819e329c9a4561f5f57f8f539346038ab5026dda8"; then
43+
echo "Checksum mismatch" >&2
44+
exit 1
45+
fi
46+
tar -C /tmp -xvzf /tmp/kustomize.tar.gz
47+
sudo mv /tmp/kustomize /usr/local/bin/kustomize
48+
chmod +x /usr/local/bin/kustomize
4449
- name: Run make manifests
4550
run: |
4651
make manifests

‎.golangci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ linters-settings:
1616
goimports:
1717
local-prefixes: github.com/argoproj-labs/argocd-image-updater
1818
service:
19-
golangci-lint-version: 1.26.0
19+
golangci-lint-version: 1.52.2

‎docs/basics/authentication.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Authentication in Argo CD Image Updater
22

33
There are several scenarios where Argo CD Image Updater needs to authenticate
4-
to external systems in order to fulfil its duties.
4+
to external systems in order to fulfill its duties.
55

66
## <a name="auth-kubernetes"></a>Authentication to Kubernetes
77

@@ -207,7 +207,7 @@ echo "someuser:s0mep4ssw0rd"
207207

208208
When executing on Kubernetes, the script to be executed must exist in the
209209
Image Updater container's file system. You can either mount the script from
210-
a config map, or use an init container to copy it. Make sure that the script
210+
a configmap, or use an init container to copy it. Make sure that the script
211211
is executable.
212212

213213
For example, if above script would exist at `/usr/local/bin/creds.sh`, it

‎docs/basics/update-methods.md

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
## Overview
44

55
Argo CD Image Updater supports several methods to propagate new versions of the
6-
images to Argo CD. These methods are also refered to as *write back methods*.
6+
images to Argo CD. These methods are also referred to as *write back methods*.
77

88
Currently, the following methods are supported:
99

@@ -144,6 +144,22 @@ kubectl -n argocd-image-updater create secret generic git-creds \
144144
--from-file=sshPrivateKey=~/.ssh/id_rsa
145145
```
146146

147+
### <a name="method-git-repository"></a>Specifying a repository when using a Helm repository in repoURL
148+
149+
By default, Argo CD Image Updater will use the value found in the Application
150+
spec at `.spec.source.repoURL` as Git repository to checkout. But when using
151+
a Helm repository as `.spec.source.repoURL` GIT will simply fail. To manually
152+
specify the repository to push the changes, specify the
153+
annotation `argocd-image-updater.argoproj.io/git-repository` on the Application
154+
manifest.
155+
156+
The value of this annotation will define the Git repository to use, for example the
157+
following would use a GitHub's repository:
158+
159+
```yaml
160+
argocd-image-updater.argoproj.io/git-repository: git@github.com:example/example.git
161+
```
162+
147163
### <a name="method-git-branch"></a>Specifying a branch to commit to
148164

149165
By default, Argo CD Image Updater will use the value found in the Application
@@ -162,7 +178,7 @@ argocd-image-updater.argoproj.io/git-branch: main
162178

163179
### <a name="method-git-base-commit-branch"></a>Specifying a separate base and commit branch
164180

165-
By default, Argo CD Imager Updater will checkout, commit, and push back to the
181+
By default, Argo CD Image Updater will checkout, commit, and push back to the
166182
same branch specified above. There are many scenarios where this is not
167183
desired or possible, such as when the default branch is protected. You can
168184
add a separate write-branch by modifying `argocd-image-updater.argoproj.io/git-branch`

‎docs/basics/update.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ The workflow of Argo CD Image Updater can be described as follows:
1818
annotation holds a list of image names that should be updated, and is a
1919
mandatory annotation for Argo CD Image Updater to indicate it should
2020
process this `Application`. Read more about the syntax expected in this
21-
annotations's value in the [marking images for update](#TODO)
21+
annotation's value in the [marking images for update](#TODO)
2222
section in this doc.
2323

2424
* For each image found in the list, Argo CD Image Updater will first check

‎docs/install/reference.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ Only process applications that have a valid annotation and match the given
123123
syntax of `key=value`. For e.g, `custom.label/name=xyz` would be a valid label
124124
that can be supplied through this parameter. Any applications carrying this
125125
exact label will be considered as candidates for image updates. This parameter
126-
currently does not support patten matching on label values (e.g `customer.label/name=*-staging`)
126+
currently does not support pattern matching on label values (e.g `customer.label/name=*-staging`)
127127
and only accepts a single label to match applications against.
128128

129129
**--max-concurrency *number* **

‎ext/git/mocks/Client.go

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)