fix: open commit URL against selected remote#5357
Open
SergioChan wants to merge 1 commit intojesseduffield:masterfrom
Open
fix: open commit URL against selected remote#5357SergioChan wants to merge 1 commit intojesseduffield:masterfrom
SergioChan wants to merge 1 commit intojesseduffield:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
originwhen building hosting-service URLs for commit linksoriginoriginURL resolution if the selected remote lookup failsWhy
When browsing commits from a non-
originremote in the Remotes/Remote Branches flow, pressingoshould open the selected remote host, not always the first remote.Fixes #5260
Testing
go test ./pkg/gui/controllers/helpers -run TestGetPreferredRemoteName