fix: preserve user-selected half screen mode when clearing filters#5361
Open
SergioChan wants to merge 1 commit intojesseduffield:masterfrom
Open
fix: preserve user-selected half screen mode when clearing filters#5361SergioChan wants to merge 1 commit intojesseduffield:masterfrom
SergioChan wants to merge 1 commit intojesseduffield:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a screen-mode regression when exiting commit filtering.
Closes #5179.
When users start filtering from
screenMode: half, clearing the filter should keep the UI in half mode. Instead, Lazygit switched back to normal mode.Root cause
ModeHelper.ClearFiltering()always convertedSCREEN_HALF -> SCREEN_NORMALon exit, without distinguishing:What changed
normal -> half) using a newscreenModeChangedflag in filtering mode state.half -> normalon filter clear when that flag is true.Validation
go test ./pkg/gui/modes/filtering ./pkg/gui/controllers/...All tests passed.