[cleanup] remove launched flags for UnifiedEnv and Lockfile; remove Disabled method (#1152)

## Summary

1. This PR removes the Disabled method. I had added it a while back
after missing a `not` operator in `!featureflag.<flag name>.Enabled()`
and wanted to make it explicit. @mikeland86 objected saying he prefers
"one way to do things" over "more natural language".
I no longer care to argue this case, so removing.

2. We've launched UnifiedEnv and Lockfile, so can remove these flags.

## How was it tested?

did not test except to see that it compiles.

Author: savil

internal/boxcli/featureflag/auth.go

@@ -3,4 +3,4 @@
 
 package featureflag
 
-var Auth = enabled("AUTH")
+var Auth = enable("AUTH")

internal/boxcli/featureflag/feature.go

@@ -18,15 +18,15 @@ type feature struct {
 
 var features = map[string]*feature{}
 
-func disabled(name string) *feature {
+func disable(name string) *feature {
 	if features[name] == nil {
 		features[name] = &feature{name: name}
 	}
 	features[name].enabled = false
 	return features[name]
 }
 
-func enabled(name string) *feature {
+func enable(name string) *feature {
 	if features[name] == nil {
 		features[name] = &feature{name: name}
 	}
@@ -54,10 +54,6 @@ func (f *feature) Enabled() bool {
 	return f.enabled
 }
 
-func (f *feature) Disabled() bool {
-	return !f.Enabled()
-}
-
 // All returns a map of all known features flags and whether they're enabled.
 func All() map[string]bool {
 	m := make(map[string]bool, len(features))

internal/boxcli/featureflag/feature_test.go

@@ -11,23 +11,23 @@ import (
 
 func TestEnabledFeature(t *testing.T) {
 	name := "TestEnabledFeature"
-	enabled(name)
+	enable(name)
 	if !features[name].Enabled() {
 		t.Errorf("got %s.Enabled() = false, want true.", name)
 	}
 }
 
 func TestDisabledFeature(t *testing.T) {
 	name := "TestDisabledFeature"
-	disabled(name)
+	disable(name)
 	if features[name].Enabled() {
 		t.Errorf("got %s.Enabled() = true, want false.", name)
 	}
 }
 
 func TestEnabledFeatureEnv(t *testing.T) {
 	name := "TestEnabledFeatureEnv"
-	disabled(name)
+	disable(name)
 	t.Setenv(envir.DevboxFeaturePrefix+name, "1")
 	if !features[name].Enabled() {
 		t.Errorf("got %s.Enabled() = false, want true.", name)

internal/boxcli/featureflag/lockfile.go

@@ -2,4 +2,4 @@ package featureflag
 
 // PromptHook controls the insertion of a shell prompt hook that invokes
 // devbox shellenv, in lieu of using binary wrappers.
-var PromptHook = disabled("PROMPT_HOOK")
+var PromptHook = disable("PROMPT_HOOK")

internal/boxcli/featureflag/prompt_hook.go

@@ -4,4 +4,4 @@ package featureflag
 // It leverages the search index to directly map <package>@<version> to
 // the /nix/store/<hash>-<package>-<version> that can be fetched from
 // cache.nixpkgs.org.
-var RemoveNixpkgs = disabled("REMOVE_NIXPKGS")
+var RemoveNixpkgs = disable("REMOVE_NIXPKGS")

internal/boxcli/featureflag/remove_nixpkgs.go

@@ -5,4 +5,4 @@ package featureflag
 
 // ScriptExitOnError controls whether scripts defined in devbox.json
 // and executed via `devbox run` should exit if any command within them errors.
-var ScriptExitOnError = disabled("SCRIPT_EXIT_ON_ERROR")
+var ScriptExitOnError = disable("SCRIPT_EXIT_ON_ERROR")

internal/boxcli/featureflag/script_exit_on_error.go

@@ -12,6 +12,7 @@ import (
 
 	"github.com/samber/lo"
 	"go.jetpack.io/devbox/internal/boxcli/featureflag"
+
 	"go.jetpack.io/devbox/internal/cuecfg"
 	"go.jetpack.io/devbox/internal/devpkg"
 )
@@ -145,11 +146,6 @@ func (l *File) ResolveToCurrentNixpkgCommitHash(pkg string) error {
 }
 
 func (l *File) Save() error {
-	// Never write lockfile if versioned packages is not enabled
-	if !featureflag.LockFile.Enabled() {
-		return nil
-	}
-
 	return cuecfg.WriteFile(lockFilePath(l.devboxProject), l)
 }
 
@@ -185,8 +181,5 @@ func lockFilePath(project devboxProject) string {
 }
 
 func getLockfileHash(project devboxProject) (string, error) {
-	if !featureflag.LockFile.Enabled() {
-		return "", nil
-	}
 	return cuecfg.FileHash(lockFilePath(project))
 }