Update plugins/builtin example to use php83 to avoid flaky tests #2733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The cli-tests on main failed on Oct 24 due to a flaky test in the php-dom extension for PHP 8.2.29:
Analysis
Evidence of PHP version difference between runs:
Oct 23 run - ✅ SUCCESS
Oct 24 run - ❌ FAILURE
The issue is specific to PHP 8.2.29 in nixpkgs-unstable.
Solution
Update the
examples/plugins/builtinexample fromphp82tophp83.This is a conservative approach because:
Changes
examples/plugins/builtin/devbox.json: Change fromplugin:php82toplugin:php83Alternative Considered
Initially considered adding
doCheck = falseto the PHP plugin flake, but updating the PHP version is cleaner and more conservative since PHP 8.3 is already known to work.Testing
This PR will trigger cli-tests. The
examples/plugins/builtintest should pass with PHP 8.3.