Generate single testcase RBAC

Author: Weeblin

pkg/permissions/generate.go

@@ -40,7 +40,7 @@ rules:
 	return strings.TrimSuffix(ss, "\n")
 }
 
-func GenerateRoles(dataGatherer []agent.DataGatherer) []rbac.ClusterRole {
+func GenerateClusterRoles(dataGatherer []agent.DataGatherer) []rbac.ClusterRole {
 	out := []rbac.ClusterRole{}
 
 	for _, g := range dataGatherer {
@@ -78,7 +78,7 @@ func GenerateRoles(dataGatherer []agent.DataGatherer) []rbac.ClusterRole {
 
 // }
 
-func GenerateBindings(clusterRoles []rbac.ClusterRole) []rbac.ClusterRoleBinding {
+func GenerateClusterRoleBindings(clusterRoles []rbac.ClusterRole) []rbac.ClusterRoleBinding {
 	out := []rbac.ClusterRoleBinding{}
 	for _, cr := range clusterRoles {
 		out = append(out, rbac.ClusterRoleBinding{

pkg/permissions/generate_test.go

@@ -14,15 +14,14 @@ import (
 func TestGenerateRBAC(t *testing.T) {
 	// Use these test cases to check if Generate function is correct
 	testCases := []struct {
-		// expectedClusterRoles is the collection of ClusterRole
+		expectedClusterRoles        []rbac.ClusterRole
 		expectedClusterRoleBindings []rbac.ClusterRoleBinding
 		dataGatherers               []agent.DataGatherer
 		description                 string
 	}{
 		{
 			description: "Generate RBAC struct for pods datagatherer",
 			dataGatherers: []agent.DataGatherer{
-
 				{
 					Name: "k8s/secrets",
 					Kind: "k8s-dynamic",
@@ -34,6 +33,24 @@ func TestGenerateRBAC(t *testing.T) {
 					},
 				},
 			},
+			expectedClusterRoles: []rbac.ClusterRole{
+				{
+					TypeMeta: metav1.TypeMeta{
+						Kind:       "ClusterRole",
+						APIVersion: "rbac.authorization.k8s.io/v1",
+					},
+					ObjectMeta: metav1.ObjectMeta{
+						Name: "jetstack-secure-agent-secrets-reader",
+					},
+					Rules: []rbac.PolicyRule{
+						{
+							Verbs:     []string{"get", "list", "watch"},
+							APIGroups: []string{""},
+							Resources: []string{"secrets"},
+						},
+					},
+				},
+			},
 			expectedClusterRoleBindings: []rbac.ClusterRoleBinding{
 				{
 					TypeMeta: metav1.TypeMeta{
@@ -62,9 +79,10 @@ func TestGenerateRBAC(t *testing.T) {
 	}
 
 	for _, input := range testCases {
-		got := GenerateRoles(input.dataGatherers)
-		toBeTest := GenerateBindings(got)
+		gotClusterRoles := GenerateClusterRoles(input.dataGatherers)
+		gotClusterRoleBindings := GenerateClusterRoleBindings(gotClusterRoles)
 
-		td.Cmp(t, input.expectedClusterRoleBindings, toBeTest)
+		td.Cmp(t, input.expectedClusterRoleBindings, gotClusterRoleBindings)
+		td.Cmp(t, input.expectedClusterRoles, gotClusterRoles)
 	}
 }