Implement simple generation of ClusterRoleses

Author: Weeblin

go.mod

@@ -21,6 +21,7 @@ require (
 	github.com/juju/testing v0.0.0-20191001232224-ce9dec17d28b // indirect
 	github.com/kylelemons/godebug v1.1.0
 	github.com/leodido/go-urn v1.2.0 // indirect
+	github.com/maxatome/go-testdeep v1.9.2 // indirect
 	github.com/pkg/errors v0.9.1
 	github.com/pmylund/go-cache v2.1.0+incompatible
 	github.com/sirupsen/logrus v1.7.0

go.sum

@@ -664,6 +664,8 @@ github.com/mattn/go-sqlite3 v1.12.0/go.mod h1:FPy6KqzDD04eiIsT53CuJW3U88zkxoIYsO
 github.com/matttproud/golang_protobuf_extensions v1.0.1/go.mod h1:D8He9yQNgCq6Z5Ld7szi9bcBfOoFv/3dc6xSMkL2PC0=
 github.com/matttproud/golang_protobuf_extensions v1.0.2-0.20181231171920-c182affec369 h1:I0XW9+e1XWDxdcEniV4rQAIOPUGDq67JSCiRCgGCZLI=
 github.com/matttproud/golang_protobuf_extensions v1.0.2-0.20181231171920-c182affec369/go.mod h1:BSXmuO+STAnVfrANrmjBb36TMTDstsz7MSK+HVaYKv4=
+github.com/maxatome/go-testdeep v1.9.2 h1:5D7u/JkeG0A/HDTbZ/CFFmpYZPeWN+uGQ1IbsEHYlCo=
+github.com/maxatome/go-testdeep v1.9.2/go.mod h1:011SgQ6efzZYAen6fDn4BqQ+lUR72ysdyKe7Dyogw70=
 github.com/mgutz/ansi v0.0.0-20170206155736-9520e82c474b/go.mod h1:01TrycV0kFyexm33Z7vhZRXopbI8J3TDReVlkTgMUxE=
 github.com/mholt/archiver/v3 v3.5.0 h1:nE8gZIrw66cu4osS/U7UW7YDuGMHssxKutU8IfWxwWE=
 github.com/mholt/archiver/v3 v3.5.0/go.mod h1:qqTTPUK/HZPFgFQ/TJ3BzvTpF/dPtFVJXdQbCmeMxwc=

pkg/permissions/generate_test.go

@@ -3,9 +3,9 @@ package permissions
 import (
 	"testing"
 
-	"github.com/d4l3k/messagediff"
 	"github.com/jetstack/preflight/pkg/agent"
 	"github.com/jetstack/preflight/pkg/datagatherer/k8s"
+	"github.com/maxatome/go-testdeep/td"
 	rbac "k8s.io/api/rbac/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime/schema"
@@ -35,28 +35,24 @@ func TestGenerateRBAC(t *testing.T) {
 				},
 			},
 			expectedClusterRoleBindings: []rbac.ClusterRoleBinding{
-
 				{
 					TypeMeta: metav1.TypeMeta{
 						Kind:       "ClusterRoleBinding",
 						APIVersion: "rbac.authorization.k8s.io/v1",
 					},
-
 					ObjectMeta: metav1.ObjectMeta{
 						Name: "jetstack-secure-agent-ClusterRole-reader",
 					},
-
 					Subjects: []rbac.Subject{
 						{
 							Kind:      "ServiceAccount",
 							Name:      "agent",
 							Namespace: "jetstack-secure",
 						},
 					},
-
 					RoleRef: rbac.RoleRef{
 						Kind:     "ClusterRole",
-						Name:     "jetstack-secure-agent-secret-reader",
+						Name:     "jetstack-secure-agent-secrets-reader",
 						APIGroup: "rbac.authorization.k8s.io",
 					},
 				},
@@ -68,9 +64,7 @@ func TestGenerateRBAC(t *testing.T) {
 	for _, input := range testCases {
 		got := GenerateRoles(input.dataGatherers)
 		toBeTest := GenerateBindings(got)
-		if diff, equal := messagediff.PrettyDiff(input.expectedClusterRoleBindings, toBeTest); !equal {
-			t.Errorf("%s:\n%s", input.description, diff)
-			t.Fatalf("unexpected difference in RBAC cluster role: \ngot \n%v\nwant\n%v", got, input.expectedClusterRoleBindings)
-		}
+
+		td.Cmp(t, input.expectedClusterRoleBindings, toBeTest)
 	}
 }