Consider all SHA's of a manifest #355
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcollom
requested review from
joshw123,
paulwilljones,
hawksight,
BeckyPauley and
aidy
davidcollom
force-pushed
the
issue-212
branch
2 times, most recently
from
003c087 to
92c8431
Compare
pkg/client/docker/types.go
Outdated
| @@ -14,6 +14,7 @@ type TagResponse struct { | |||
| type Result struct { | |||
| Name string `json:"name"` | |||
| Timestamp string `json:"last_updated"` | |||
| Digest string `json:"digest,omitempty"` | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I discovered it whilst looking up / using some test/sample data - I.E: within the current response:
https://registry.hub.docker.com/v2/repositories/davidcollom/hub3-exporter/tags
aidy
reviewed
Apr 7, 2025
aidy
reviewed
Apr 8, 2025
aidy
reviewed
Apr 8, 2025
|
|
||
| // If this is a Manifest list we need to keep them together | ||
| Children []*ImageTag `json:"children,omitempty"` | ||
| } |
There was a problem hiding this comment.
I suspect that it would be better to represent this as
type ImageTag struct {
Tag string
Manifests []Manifest
}
type Manifest {
SHA string
Timestamp time.Time
OS OS
Architecture Architecture
}
|
Do you think some of this PR can be moved into another (like GitHub Actions)? |
There was a problem hiding this comment.
There's a lot going on here, not all of it relates to the getting the SHAs in manifests. Could it be broken down into 2-3 other PRs?
Otherwise, only main nit is moving the logic when building the parent/child tag map into one place and reuse it across clients.
davidcollom
commented
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was initially started in bringing OS/Arch Support to version-checker, but as things progressed.
I releasied that whilst it would be nice and efficient if we only returned Tags that were for the macthing OS, it felt like we'd be caching more and more of the same data (albeit for different os/arch)
Therefore, adding a Children/Child field to an ImageTag allows us to add multiple SHA's to the same tag (essentially brining multi-arch). Caching this as all one object also means we cache it once!
if a Tag were to be updated, then all SHA Digests would be updated and modified so the same outcome occurs as before.
I have tested this with the following Clients:
resolves #181