Track Kubernetes Channels for latest versions #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This look great! It would be great to mention this new feature to the README.md |
davidcollom
commented
Jul 25, 2025
|
|
||
| if err := c.SetupWithManager(mgr); err != nil { | ||
| kubeController := controller.NewKubeReconciler( |
There was a problem hiding this comment.
I was thinking, if it's worth checking ig opts.KubeChannel is not empty, and not starting the kubernetes channel version Reconciler... Maybe that's the SetupWithManager's responsibility? wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a kubernetes version checking ability, it uses the official k8s channels .txt file and defaults to "stable" for its release channel, this can be overriden with a cli flag
Things outstanding:
Stretch goals and more longer term idea's:
gkedetected within the version string