Test e2e #364
Test e2e #364
Conversation
klone.yaml
Outdated
There was a problem hiding this comment.
i'm not a huge fan of the make file modules etc... I'd rather see things like kind clusters etc being provisioned within the testing suite/framework rather than a lot of make targets, that way the number of tools needed to run is far simpler and easier to achieve for new comers to the project.
There was a problem hiding this comment.
Agreed, it complicates things using the modules but does add a lot of functionality for free. Do you mean the testing framework should spin up dependencies (like kind), so specifically in the testing make targets or in Go? I was tempted to move the helm prerequisites (installing the selfhosted registry into kind for example) from make and into the framework using the helm go client.
| req.Header.Set("Accept", header) | ||
| req.Header.Add("Accept", ociV1Header) |
There was a problem hiding this comment.
Should this be a comma-separated list? https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.1
| req.Header.Set("Accept", header) | |
| req.Header.Add("Accept", ociV1Header) | |
| req.Header.Set("Accept", strings.Join(",", []string{header,ociV1Header}) |
No description provided.