Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the attachment download selection limits in the Query UI to be plan- and platform-aware (higher for paid web users, lower for free web users, and intended to be unlimited for desktop/extension), and documents the new limits.
Changes:
- Adjusts shared constants to set the base max download record count to 250 and introduces a paid-user max of 2,000.
- Updates Query Results attachment download UI to use
hasPaidPlanand platform detection to determine limits and user messaging. - Adds documentation clarifying plan-based limits and platform behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| libs/shared/constants/src/lib/shared-constants.ts | Changes the global max record limit and introduces a paid-user max constant. |
| libs/features/query/src/QueryResults/QueryResultsAttachmentDownload.tsx | Implements plan/platform-based record limit logic and updates disabled-state messaging. |
| libs/features/query/src/QueryResults/QueryResults.tsx | Wires hasPaidPlan from app-state into the attachment download component. |
| apps/docs/docs/query/download-attachments.mdx | Documents the updated limits and platform-specific behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
63d581b to
a728d0a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
libs/features/query/src/QueryResults/QueryResultsAttachmentDownload.tsx
Outdated
Show resolved
Hide resolved
apps/jetstream-web-extension/src/controllers/sf-misc.web-ext.controller.ts
Outdated
Show resolved
Hide resolved
e4b652e to
da93f52
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
libs/features/query/src/QueryResults/QueryResultsAttachmentDownload.tsx:50
binaryCompatibleObjectsis built fromObject.keys(BinaryDownloadCompatibleObjectsSchema.enum)(mixed-case values likeCombinedAttachment), but the component andQueryResults.tsxcheck membership usingsobjectName.toLowerCase(). This meansCombinedAttachmentwill never be considered compatible and the download UI will not appear for that object. Normalize the enum values when building the set (e.g., lower-case all entries) or stop lowercasing the lookup so the casing is consistent.
export const binaryCompatibleObjects = new Set(Object.keys(BinaryDownloadCompatibleObjectsSchema.enum));
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
For the web application, paid users can now download up to 2000 attachments at a time. Free users have a reduced limit of 250 attachments per download. Desktop and browser extension users do not have a limit imposed since these do not require server resources Increased download limit from 500MB to 1GB across all files in a single download. Ref: resolves #1527
For the web application, paid users can now download up to 2000 attachments at a time. Free users have a reduced limit of 250 attachments per download.
Desktop and browser extension users do not have a limit imposed since these do not require server resources
Ref: resolves #1527