From 0e9ec31d50d5dc4056b4e259d7047603ae513216 Mon Sep 17 00:00:00 2001 From: Elvys Soares Date: Sun, 26 Jul 2020 22:44:59 -0300 Subject: [PATCH] Removed assertion roulette (test smell) --- src/test/java/org/jfaster/mango/jdbc/MapperTest.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/test/java/org/jfaster/mango/jdbc/MapperTest.java b/src/test/java/org/jfaster/mango/jdbc/MapperTest.java index 065f6756..a2d94c94 100644 --- a/src/test/java/org/jfaster/mango/jdbc/MapperTest.java +++ b/src/test/java/org/jfaster/mango/jdbc/MapperTest.java @@ -25,6 +25,8 @@ import org.jfaster.mango.support.DataSourceConfig; import org.jfaster.mango.support.Table; import org.jfaster.mango.support.model4table.Msg; +import org.junit.Assert; +import org.junit.Assume; import org.junit.Before; import org.junit.Test; @@ -63,16 +65,13 @@ public void test() { List ids = new ArrayList(); for (Msg msg : msgs) { int id = dao.insert(msg.getUid(), msg.getContent()); - assertThat(id, greaterThan(0)); + Assume.assumeThat(id, greaterThan(0)); msg.setId(id); ids.add(id); } List dbMsgs = dao.getMsgs(ids); - assertThat(dbMsgs, hasSize(msgs.size())); - assertThat(dbMsgs, containsInAnyOrder(msgs.toArray())); - Msg msg = msgs.get(0); - assertThat(dao.getMsg(msg.getId()), equalTo(msg)); + Assert.assertArrayEquals(msgs.toArray(), dbMsgs.toArray()); } @DB(table = "msg")