Skip to content

refactor(AbstractNamedBuilderFactory): extract method #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(AbstractNamedBuilderFactory): extract method #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions src/main/java/org/jfaster/mango/crud/named/factory/AbstractNamedBuilderFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,22 +72,33 @@ private int metchSize(String name) {
return 0;
}

private int getCountOfOpUnitParams(List<OpUnit> opUnits) {
int countOfOpUnitParams = 0;

for (OpUnit opUnit : opUnits) {
countOfOpUnitParams += opUnit.getOp().paramCount();
}

return countOfOpUnitParams;
}

protected void buildWhereClause(
StringBuilder tailOfSql, List<OpUnit> opUnits, List<String> logics,
CrudMeta cm, List<Type> parameterTypes, String methodName, Class<?> clazz) {
int countOfOpUnitParams;

if (opUnits.size() == 0) {
throw new IllegalStateException(); // TODO msg
}
if (opUnits.size() != (logics.size() + 1)) {
throw new IllegalStateException(); // TODO msg
}
int count = 0;
for (OpUnit opUnit : opUnits) {
count = count + opUnit.getOp().paramCount();
}
if (parameterTypes.size() < count) {

countOfOpUnitParams = getCountOfOpUnitParams(opUnits);

if (parameterTypes.size() < countOfOpUnitParams) {
throw new CrudException("the name of method [" + methodName + "] is error, " +
"the number of parameters expected greater or equal than " + count + ", but " + parameterTypes.size());
"the number of parameters expected greater or equal than " + countOfOpUnitParams + ", but " + parameterTypes.size());
}
tailOfSql.append("where ");
int paramIndex = 1;
Expand Down