cli: bookmark, tag: migrate to parse_union_name_patterns() #8142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuja
force-pushed
the
push-qlpzxxrvlsrn
branch
2 times, most recently
from
3b381bf to
25e0a72
Compare
This prepares for migration to parse_union_name_patterns(). find_bookmarks*() will be inlined, and new helper function for unmatched warnings will be added.
"jj bookmark move" no longer shows a warning for named bookmarks not pointing to the --from revisions. I think that's okay. `move --from=REV 'PATTERN ~ main'` is a valid use case, and "main" shouldn't be warned.
yuja
force-pushed
the
push-qlpzxxrvlsrn
branch
from
25e0a72 to
d3a7824
Compare
martinvonz
approved these changes
Dec 1, 2025
Member
martinvonz
left a comment
martinvonz
left a comment
There was a problem hiding this comment.
Makes sense to make these similar to how e.g. jj diff non-existent behaves (i.e. just warning that the file wasn't matched). Hopefully the fact that we have commands that already just warn means that people will not miss the error here either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.mdREADME.md,docs/,demos/)cli/src/config-schema.json)