Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
branches:
- master
tags: '*'
workflow_dispatch:
jobs:
test:
name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }}
Expand All @@ -17,18 +18,17 @@ jobs:
version:
- '1.9' # Replace this with the minimum Julia version that your package supports. E.g. if your package requires Julia 1.5 or higher, change this to '1.5'.
- '1' # Leave this line unchanged. '1' will automatically expand to the latest stable 1.x release of Julia.
- 'nightly'
os:
- ubuntu-latest
arch:
- x64
steps:
- uses: actions/checkout@v2
- uses: julia-actions/setup-julia@v1
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
with:
version: ${{ matrix.version }}
arch: ${{ matrix.arch }}
- uses: actions/cache@v1
- uses: actions/cache@v4
env:
cache-name: cache-artifacts
with:
Expand All @@ -41,6 +41,6 @@ jobs:
- uses: julia-actions/julia-buildpkg@v1
- uses: julia-actions/julia-runtest@v1
- uses: julia-actions/julia-processcoverage@v1
- uses: codecov/codecov-action@v1
- uses: codecov/codecov-action@v5
with:
file: lcov.info
files: lcov.info
4 changes: 2 additions & 2 deletions Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "GLFixedEffectModels"
uuid = "bafb0ae5-e5f5-5100-81b6-6a55d777c812"
authors = ["Johannes Boehm <johannes.boehm@gmail.com>"]
version = "0.5.4"
version = "0.5.5"

[deps]
DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
Expand All @@ -24,7 +24,7 @@ Vcov = "ec2bfdc2-55df-4fc9-b9ae-4958c2cf2486"
DataFrames = "1"
Distributions = "0.25"
FillArrays = "1"
FixedEffectModels = "1.7,1.8,1.9,1.10,1.11"
FixedEffectModels = "1.12"
FixedEffects = "2.1,2.2,2.3"
GLM = "^1.3.6"
LoopVectorization = "0.12"
Expand Down
4 changes: 1 addition & 3 deletions src/fit.jl
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,7 @@ function nlreg(@nospecialize(df),
if has_fes
if drop_singletons
before_n = sum(esample)
for fe in fes
FixedEffectModels.drop_singletons!(esample, fe)
end
FixedEffectModels.drop_singletons!(esample, fes, nthreads)
after_n = sum(esample)
dropped_n = before_n - after_n
if dropped_n > 0
Expand Down
Loading