add O_DIRECT for Linux x86_64 and aarch64 (#107) #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw https://github.com/jruby/jruby/blob/master/core/src/main/java/org/jruby/RubyFile.java#L198 should be updated as well to make it available from JRuby |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @headius . Thank you for the quick response. The constants generated match the bitmasks we ended up hardcoding into our application for
O_DIRECT, so the values have been tested in situ.A few comments/questions (somewhat) related to this PR:
The
regen:platformresulted in updates to AddressFamily.java and ProtocolFamily.java on Linux x86_64 and aarch64. Since they aren't directly related to this change, I left them out. Should I include them? Should I submit a separate PR?When I run on Apple M1 (
uname -sm -> Darwin arm64), it creates a new directorysrc/main/java/jnr/constants/platform/darwin/x86_64/. I was expecting it to generatedarwin/aarch64. I assume this is a quirk of the M1.O_DIRECTisn't defined on Darwin, so it doesn't matter for this PR anyway.When I ran
rake regen:lplatformon Linux x86_64, it creates a new foldersrc/main/java/jnr/constants/platform/linux/x86_64/, which seems correct. Runningrake regen:platformupdates ``src/main/java/jnr/constants/platform/linux/`. Is the use of the latter a convention?