Skip to content

refactor: simplify provider setup #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2024
Merged

refactor: simplify provider setup #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions projects/material-css-vars/src/lib/material-css-vars.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,16 @@ import { MaterialCssVarsService } from "./material-css-vars.service";
@NgModule({
imports: [CommonModule],
})
// eslint-disable-next-line @typescript-eslint/no-extraneous-class
export class MaterialCssVarsModule {
static forRoot(
config?: Partial<MaterialCssVariablesConfig>,
): ModuleWithProviders<MaterialCssVarsModule> {
return {
ngModule: MaterialCssVarsModule,
providers: [{ provide: MATERIAL_CSS_VARS_CFG, useValue: config }],
providers: [provideMaterialCssVars(config)],
};
}

// This is necessary, so the service is constructed, even if the service is never injected
// ToDo: change to environment initializer, like in the provideMaterialCssVars() function below
constructor(private materialCssVarsService: MaterialCssVarsService) {}
}

export function provideMaterialCssVars(
Expand Down