Skip to content

Conversation

jvanasco
Copy link
Contributor

A reverse domain notation function, as offered in #342

@john-kurkowski
Copy link
Owner

Thank you! I was picturing this as a new property. Rather than expand the entrypoints into this library. See cff0327. What do you think?

@jvanasco
Copy link
Contributor Author

Interesting. LGTM as a property of ExtractResult and I can see how that makes sense for many use-cases!

@john-kurkowski john-kurkowski changed the title Feature rdns Add reverse domain name notation property Mar 26, 2025
@john-kurkowski john-kurkowski merged commit 4435a5e into john-kurkowski:master Mar 26, 2025
24 checks passed
@john-kurkowski
Copy link
Owner

Thanks for the contribution!

@jvanasco
Copy link
Contributor Author

You're welcome!

FYI, I realized last night that I greatly prefer your idea to implement this as a property of ExtractResult. This isn't a true reverse domain notation - it's a slight adaptation of the concept (although it is what most people implement IRL) based on the TLD. As such, it makes much more sense as a property of the ExtractResult than a standalone function.

@john-kurkowski
Copy link
Owner

This isn't a true reverse domain notation - it's a slight adaptation of the concept (although it is what most people implement IRL) based on the TLD.

Good catch. I noted this in ffd6203.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants