Re-render single pages when paginating fixed layout #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the fixed layout renderer is in single page ("portrait") mode and the pages have different sizes and shapes, not re-rendering pages on #goLeft and #goRight can result (when the page change takes place within a spread) in pages retaining a downscale that matches a spread that's not visible, yielding a view with undesired margins/wasted space.
In the same circumstances, if paginating into the same page from outside the spread or directly using goTo, the page is re-rendered, which means it will take up the full available space. This is inconsistent and confusing.
This is a simple fix that ensures pages are always re-rendered in portrait mode and therefore always have the correct dimensions. I figured if the resize observer calls
#render
, it should be acceptable here as well, but feel free to amend the fix to make it more focused if possible.