Adds wordpress detection #131
Conversation
There was a problem hiding this comment.
Someone brought up
Since WordPress 4.4, there should be a link element in the header with a rel attribute equal to api.w.org and a href attribute equal to the site's URL.
I think that's our strongest signal. Falling back on wp-includes sg.
I was thinking something like this, but I'm open to alternatives..
const hasAPILinkElem = ....
const hasWPIncludes = ...
if (!hasAPILinkElem || !hasWPIncludes) return false;
const generatorMeta = ...
const version = ...
if (version) return { version }
else return { version: UNKNOWN_VERSION };
library/libraries.js
Outdated
| test: function (win) { | ||
| if (!!document.querySelector('meta[name=generator][content^="WordPress"]')) { | ||
| var versionName = document.querySelector("meta[name='generator']").getAttribute("content"); | ||
| return { version: versionName.replace(/[^0-9\.]+/g,"") }; |
There was a problem hiding this comment.
over on https://wordpress.org/news/ i spotted WordPress 5.2-alpha-44796 so I think we'll need something different..
.replace(/^\w+\s/,'') perhaps?
There was a problem hiding this comment.
That's right. The version can look like any one of:
5.1.25.1-beta25.0-RC15.2-alpha-44742-src
So yes, just removing 'WordPress ' from the beginning will be the way to go.
There was a problem hiding this comment.
Ooh didn't know more than just numbered releases could be included. Fixed 👍
|
@paulirish Updated it to your suggestion. I think it looks good. One thing however: I used CC @Shelob9 |
|
@housseindjirdeh This looks good to me. |
|
Note: As of WordPress 6.3.0, sites will no longer be outputting this <link rel="wlwmanifest" type="application/wlwmanifest+xml" href="https://example.com/wp-includes/wlwmanifest.xml">The logic needs to be updated to not depend on it. See #203. |
CC @wardpeet @paulirish