Merge bitcoin-core/gui-qml#442: Introduce the Desktop Wallet Activity Page

565819d qml: Introduce the Desktop Wallet Activity Page (johnny9)

Pull request description:

  This commit introduces the basic Activity Page and Activity details Page. The pages are backed by activitylistmodel which queries the wallet interface and converts the WalletTx objects into Transaction objects in the list that returns the properties for each send/receive to one of our wallet's addresses.

  ![Screenshot from 2025-03-10 11-27-20](https://github.com/user-attachments/assets/d2021b25-612d-464a-a49d-cce317a4a28b)

  ![Screenshot from 2025-03-10 11-27-29](https://github.com/user-attachments/assets/ca6f2533-67f2-45f0-81ca-b45152e56a80)

ACKs for top commit:
  hebasto:
    ACK 565819d, I have skimmed through the code and it looks OK.

Tree-SHA512: febbf0d38b26932d34d69490d6db117eb6e25e55cc412138c7f0d38476325a03fd734fe1f2abc99d8312fc476315c50d7cc623349b8ec95a54dd2a5e1d7ec7a3

Author: hebasto

qml/bitcoin.cpp

@@ -16,12 +16,14 @@
 #include <noui.h>
 #include <qml/appmode.h>
 #include <qml/bitcoinamount.h>
+#include <qml/clipboard.h>
 #ifdef __ANDROID__
 #include <qml/androidnotifier.h>
 #endif
 #include <qml/components/blockclockdial.h>
 #include <qml/controls/linegraph.h>
 #include <qml/guiconstants.h>
+#include <qml/models/activitylistmodel.h>
 #include <qml/models/chainmodel.h>
 #include <qml/models/networktraffictower.h>
 #include <qml/models/nodemodel.h>
@@ -326,12 +328,15 @@ int QmlGuiMain(int argc, char* argv[])
     engine.rootContext()->setContextProperty("needOnboarding", need_onboarding);
 
     AppMode app_mode = SetupAppMode();
+    Clipboard clipboard;
 
     qmlRegisterSingletonInstance<AppMode>("org.bitcoincore.qt", 1, 0, "AppMode", &app_mode);
+    qmlRegisterSingletonInstance<Clipboard>("org.bitcoincore.qt", 1, 0, "Clipboard", &clipboard);
     qmlRegisterType<BlockClockDial>("org.bitcoincore.qt", 1, 0, "BlockClockDial");
     qmlRegisterType<LineGraph>("org.bitcoincore.qt", 1, 0, "LineGraph");
     qmlRegisterUncreatableType<PeerDetailsModel>("org.bitcoincore.qt", 1, 0, "PeerDetailsModel", "");
     qmlRegisterType<BitcoinAmount>("org.bitcoincore.qt", 1, 0, "BitcoinAmount");
+    qmlRegisterUncreatableType<Transaction>("org.bitcoincore.qt", 1, 0, "Transaction", "");
 
 #ifdef ENABLE_WALLET
     qmlRegisterUncreatableType<WalletQmlModel>("org.bitcoincore.qt", 1, 0, "WalletQmlModel",

qml/bitcoin_qml.qrc

@@ -32,14 +32,15 @@
         <file>controls/InformationPage.qml</file>
         <file>controls/IPAddressValueInput.qml</file>
         <file>controls/KeyValueRow.qml</file>
+        <file>controls/LabeledTextInput.qml</file>
         <file>controls/NavButton.qml</file>
-        <file>controls/PageIndicator.qml</file>
         <file>controls/NavigationBar.qml</file>
         <file>controls/NavigationBar2.qml</file>
         <file>controls/NavigationTab.qml</file>
         <file>controls/OptionButton.qml</file>
         <file>controls/OptionSwitch.qml</file>
         <file>controls/OutlineButton.qml</file>
+        <file>controls/PageIndicator.qml</file>
         <file>controls/PageStack.qml</file>
         <file>controls/ProgressIndicator.qml</file>
         <file>controls/qmldir</file>
@@ -72,6 +73,8 @@
         <file>pages/settings/SettingsProxy.qml</file>
         <file>pages/settings/SettingsStorage.qml</file>
         <file>pages/settings/SettingsTheme.qml</file>
+        <file>pages/wallet/Activity.qml</file>
+        <file>pages/wallet/ActivityDetails.qml</file>
         <file>pages/wallet/CreateBackup.qml</file>
         <file>pages/wallet/CreateConfirm.qml</file>
         <file>pages/wallet/CreateIntro.qml</file>
@@ -97,6 +100,7 @@
         <file alias="caret-right">res/icons/caret-right.png</file>
         <file alias="check">res/icons/check.png</file>
         <file alias="copy">res/icons/copy.png</file>
+        <file alias="coinbase">res/icons/coinbase.png</file>
         <file alias="cross">res/icons/cross.png</file>
         <file alias="error">res/icons/error.png</file>
         <file alias="export">res/icons/export.png</file>
@@ -116,6 +120,8 @@
         <file alias="storage-light">res/icons/storage-light.png</file>
         <file alias="tooltip-arrow-dark">res/icons/tooltip-arrow-dark.png</file>
         <file alias="tooltip-arrow-light">res/icons/tooltip-arrow-light.png</file>
+        <file alias="triangle-down">res/icons/triangle-down.png</file>
+        <file alias="triangle-up">res/icons/triangle-up.png</file>
         <file alias="wallet">res/icons/wallet.png</file>
         <file alias="visible">res/icons/visible.png</file>
     </qresource>

qml/clipboard.h

@@ -0,0 +1,27 @@
+// Copyright (c) 2024 The Bitcoin Core developers
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+#ifndef BITCOIN_QML_CLIPBOARD_H
+#define BITCOIN_QML_CLIPBOARD_H
+
+#include <QObject>
+#include <QClipboard>
+#include <QGuiApplication>
+
+class Clipboard : public QObject
+{
+    Q_OBJECT
+public:
+    explicit Clipboard(QObject *parent = nullptr) : QObject(parent) {}
+
+    Q_INVOKABLE void setText(const QString &text) {
+        QGuiApplication::clipboard()->setText(text);
+    }
+
+    Q_INVOKABLE QString text() const {
+        return QGuiApplication::clipboard()->text();
+    }
+};
+
+#endif // BITCOIN_QML_CLIPBOARD_H

qml/controls/LabeledTextInput.qml

@@ -18,21 +18,23 @@ Item {
     signal textEdited
 
     id: root
-    implicitHeight: label.height + input.height
+    implicitHeight: input.height
 
     CoreText {
         id: label
         anchors.left: parent.left
-        anchors.top: parent.top
-        color: Theme.color.neutral7
-        font.pixelSize: 15
+        anchors.verticalCenter: parent.verticalCenter
+        horizontalAlignment: Text.AlignLeft
+        width: 110
+        color: Theme.color.neutral9
+        font.pixelSize: 18
     }
 
     TextField {
         id: input
-        anchors.left: parent.left
+        anchors.left: label.right
         anchors.right: iconContainer.left
-        anchors.bottom: parent.bottom
+        anchors.verticalCenter: parent.verticalCenter
         leftPadding: 0
         font.family: "Inter"
         font.styleName: "Regular"

qml/imageprovider.cpp

@@ -72,6 +72,11 @@ QPixmap ImageProvider::requestPixmap(const QString& id, QSize* size, const QSize
         return QIcon(":/icons/caret-right").pixmap(requested_size);
     }
 
+    if (id == "coinbase") {
+        *size = requested_size;
+        return QIcon(":/icons/coinbase").pixmap(requested_size);
+    }
+
     if (id == "check") {
         *size = requested_size;
         return QIcon(":/icons/check").pixmap(requested_size);
@@ -167,6 +172,16 @@ QPixmap ImageProvider::requestPixmap(const QString& id, QSize* size, const QSize
         return QIcon(":/icons/tooltip-arrow-light").pixmap(requested_size);
     }
 
+    if (id == "triangle-up") {
+        *size = requested_size;
+        return QIcon(":/icons/triangle-up").pixmap(requested_size);
+    }
+
+    if (id == "triangle-down") {
+        *size = requested_size;
+        return QIcon(":/icons/triangle-down").pixmap(requested_size);
+    }
+
     if (id == "add-wallet-dark") {
         *size = requested_size;
         return QIcon(":/icons/add-wallet-dark").pixmap(requested_size);

qml/models/activitylistmodel.cpp

@@ -0,0 +1,156 @@
+// Copyright (c) 2024-2025 The Bitcoin Core developers
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+#include <qml/models/activitylistmodel.h>
+
+#include <qml/models/walletqmlmodel.h>
+
+ActivityListModel::ActivityListModel(WalletQmlModel *parent)
+    : QAbstractListModel(parent)
+    , m_wallet_model(parent)
+{
+    if (m_wallet_model != nullptr) {
+        refreshWallet();
+        subsctribeToCoreSignals();
+    }
+}
+
+ActivityListModel::~ActivityListModel()
+{
+    unsubscribeFromCoreSignals();
+}
+
+int ActivityListModel::rowCount(const QModelIndex &parent) const
+{
+    Q_UNUSED(parent)
+    return m_transactions.size();
+}
+
+void ActivityListModel::updateTransactionStatus(QSharedPointer<Transaction> tx) const
+{
+    if (m_wallet_model == nullptr) {
+        return;
+    }
+    interfaces::WalletTxStatus wtx;
+    int num_blocks;
+    int64_t block_time;
+    if (m_wallet_model->tryGetTxStatus(tx->hash, wtx, num_blocks, block_time)) {
+        tx->updateStatus(wtx, num_blocks, block_time);
+    } else {
+        tx->status = Transaction::Status::NotAccepted;
+    }
+}
+
+QVariant ActivityListModel::data(const QModelIndex &index, int role) const
+{
+    if (!index.isValid() || index.row() < 0 || index.row() >= m_transactions.size())
+        return QVariant();
+
+    QSharedPointer<Transaction> tx = m_transactions.at(index.row());
+    updateTransactionStatus(tx);
+
+    switch (role) {
+    case AddressRole:
+        return tx->address;
+    case AmountRole:
+        return tx->prettyAmount();
+    case DateTimeRole:
+        return tx->dateTimeString();
+    case DepthRole:
+        return tx->depth;
+    case LabelRole:
+        return tx->label;
+    case StatusRole:
+        return tx->status;
+    case TypeRole:
+        return tx->type;
+    default:
+        return QVariant();
+    }
+}
+
+QHash<int, QByteArray> ActivityListModel::roleNames() const
+{
+    QHash<int, QByteArray> roles;
+    roles[AddressRole] = "address";
+    roles[AmountRole] = "amount";
+    roles[DateTimeRole] = "date";
+    roles[DepthRole] = "depth";
+    roles[LabelRole] = "label";
+    roles[StatusRole] = "status";
+    roles[TypeRole] = "type";
+    return roles;
+}
+
+void ActivityListModel::refreshWallet()
+{
+    if (m_wallet_model == nullptr) {
+        return;
+    }
+    for (const auto &tx : m_wallet_model->getWalletTxs()) {
+        auto transactions = Transaction::fromWalletTx(tx);
+        m_transactions.append(transactions);
+        for (const auto &transaction : transactions) {
+            updateTransactionStatus(transaction);
+        }
+    }
+    std::sort(m_transactions.begin(), m_transactions.end(),
+              [](const QSharedPointer<Transaction> &a, const QSharedPointer<Transaction> &b) {
+                  return a->depth < b->depth;
+              });
+}
+
+void ActivityListModel::updateTransaction(const uint256& hash, const interfaces::WalletTxStatus& tx_status, int num_blocks, int64_t block_time)
+{
+    int index = findTransactionIndex(hash);
+
+    if (index != -1) {
+        QSharedPointer<Transaction> tx = m_transactions.at(index);
+        tx->updateStatus(tx_status, num_blocks, block_time);
+        Q_EMIT dataChanged(this->index(index), this->index(index));
+    } else {
+        // new transaction
+        interfaces::WalletTx wtx = m_wallet_model->getWalletTx(hash);
+        auto transactions = Transaction::fromWalletTx(wtx);
+        for (const auto& tx : transactions) {
+            tx->updateStatus(tx_status, num_blocks, block_time);
+            m_transactions.push_front(tx);
+        }
+        Q_EMIT dataChanged(this->index(0), this->index(m_transactions.size() - 1));
+    }
+}
+
+
+int ActivityListModel::findTransactionIndex(const uint256& hash) const
+{
+    auto it = std::find_if(m_transactions.begin(), m_transactions.end(),
+                           [&hash](const QSharedPointer<Transaction>& tx) {
+                               return tx->hash == hash;
+                           });
+    if (it != m_transactions.end()) {
+        return std::distance(m_transactions.begin(), it);
+    }
+    return -1;
+}
+
+void ActivityListModel::subsctribeToCoreSignals()
+{
+    // Connect signals to wallet
+    m_handler_transaction_changed = m_wallet_model->handleTransactionChanged([this](const uint256& hash, ChangeType status) {
+        interfaces::WalletTxStatus wtx;
+        int num_blocks;
+        int64_t block_time;
+        if (m_wallet_model->tryGetTxStatus(hash, wtx, num_blocks, block_time)) {
+            updateTransaction(hash, wtx, num_blocks, block_time);
+        }
+    });
+}
+
+void ActivityListModel::unsubscribeFromCoreSignals()
+{
+    // Disconnect signals from wallet
+    if (m_handler_transaction_changed) {
+        m_handler_transaction_changed->disconnect();
+    }
+}

qml/models/activitylistmodel.h

@@ -0,0 +1,57 @@
+// Copyright (c) 2024-2025 The Bitcoin Core developers
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+#ifndef BITCOIN_QML_MODELS_ACTIVITYLISTMODEL_H
+#define BITCOIN_QML_MODELS_ACTIVITYLISTMODEL_H
+
+#include <interfaces/handler.h>
+#include <interfaces/wallet.h>
+#include <qml/models/transaction.h>
+
+#include <memory>
+#include <QAbstractListModel>
+#include <QList>
+#include <QSharedPointer>
+#include <QString>
+
+class WalletQmlModel;
+
+class ActivityListModel : public QAbstractListModel
+{
+    Q_OBJECT
+
+public:
+    explicit ActivityListModel(WalletQmlModel * parent = nullptr);
+    ~ActivityListModel();
+
+    enum TransactionRoles {
+        AddressRole = Qt::UserRole + 1,
+        AmountRole,
+        DateTimeRole,
+        DepthRole,
+        LabelRole,
+        StatusRole,
+        TypeRole
+    };
+
+    int rowCount(const QModelIndex &parent = QModelIndex()) const override;
+    QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
+    QHash<int, QByteArray> roleNames() const override;
+
+private:
+    void refreshWallet();
+    void updateTransactionStatus(QSharedPointer<Transaction> tx) const;
+    void subsctribeToCoreSignals();
+    void unsubscribeFromCoreSignals();
+    void updateTransaction(const uint256& hash, const interfaces::WalletTxStatus& wtx,
+                           int num_blocks, int64_t block_time);
+    int findTransactionIndex(const uint256& hash) const;
+
+    QList<QSharedPointer<Transaction>> m_transactions;
+    WalletQmlModel* m_wallet_model;
+    std::unique_ptr<interfaces::Handler> m_handler_transaction_changed;
+    std::unique_ptr<interfaces::Handler> m_handler_show_progress;
+};
+
+#endif // BITCOIN_QML_MODELS_ACTIVITYLISTMODEL_H