Closed
Conversation
- Added new DOI provider with correct implementation - Removed incorrect DOI implementation from Spanish locale - Added tests for DOI provider - Updated CHANGELOG.md
- Added Brazilian ISBN provider with group code 85
- Ensured Faker('pt_BR') generating ISBNs with Brazilian group prefix
- Added tests to verify Brazilian ISBN generation
- Fixed the issue where pt_BR locale ignored locale and generated international ISBNs
Contributor
Author
|
Thank you in advance for review ❤️ |
fcurella
requested changes
Jul 15, 2025
faker/providers/doi/__init__.py
Outdated
| Format: 10.{4-9 digits}/{alphanumeric string} | ||
| Eg: 10.1000/xyz123 | ||
|
|
||
| fix/brazilian-isbn-locale |
Collaborator
There was a problem hiding this comment.
could you remove those lines?
fcurella
requested changes
Jul 30, 2025
- Updated documentation to clarify new format (AA-999-AA) since 2009 - Added specific methods for new and old format license plates - Added comprehensive tests for both formats - New format is properly prioritized
fcurella
requested changes
Aug 26, 2025
Collaborator
|
The PR contains changes that have nothing to do with the ISBN provider (eg I see some changes to the automotive one). Could you please clean up your branch to contain only changes to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change
Fixed Brazilian ISBN locale support (issue #2216)
What was wrong
When user was using
Faker('pt_BR'), theisbn10()andisbn13()methods were generating ISBNs with group codes like0or1(which are the US/UK regions) instead of the Brazilian group code85, absolutely ignoring the configured locale.How this fixes it
faker/providers/isbn/pt_BR/__init__.py) with group code85.Faker('pt_BR')generating ISBN's with Brazilian group prefix.Fixes #...
faker/providers/isbn/pt_BR/__init__.py-> Brazilian ISBN provider.tests/providers/test_isbn.py-> Added detailed test for Brazilian ISBN generation.Tests:
All tests passed, new tests verified, followed black & flake & mypy.
0-9720769-8-0(US/UK)85-3225-314-8(Brazilian 85)Checklist
make lint