Allow files with CR newline #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tweak query window UI remove dinging when Enter or Tab pressed in query window.
|
I tried running CsvQuery on NPP 7.3.3 64bit and this plugin made Notepad++ crash. This doesn't happen on NPP 7.3.3 32bit. |
|
NPP did some changes to the x64 internal workings in 8.3, so a plugin released after that (1.2.9) will not work with a N++ version before 8.3. If you HAVE to use a v7 of N++, you have to use an old version of CsvQuery as well, i.e. v1.2.8 or older. |
|
Thanks for the tip about older versions. I just keep a lot of NPP versions installed on my computer for testing. If you wanted the minimum viable fix for this bug, I would just apply my simple changes to CsvSettings.cs and keep my new test and my new test file. |
|
I'll take a look as soon as possible (this is a hobby project)! Thanks for
the PR!
…On Tue, 14 Mar 2023 at 15:18, molsonkiko ***@***.***> wrote:
Thanks for the tip about older versions. I just keep a lot of NPP versions
installed on my computer for testing.
If you wanted the minimum viable fix for this bug, I would just apply my
simple changes to CsvSettings.cs
<3ec3756#diff-8cf81cf3fa608e27b47580f2da35d8fe1ea5521191e6cf0a2695c957c1dcdc72>
and keep my new test
<3ec3756#diff-80a6e10777f7ad218b48078fede57a76bfef338553b6f8e081903dfbffe902f6>
and my new test file
<3ec3756#diff-7e8db74b353fcb9a691d905ae313a5fa8a9593f8d60b2d4b1f3266cb9cb6d223>
.
—
Reply to this email directly, view it on GitHub
<#43 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGRR3GLDJJCZTS6IEXJ7RDW4B44BANCNFSM6AAAAAAVZWHXTI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously files with CRLF and LF newlines were supported, but not CR. Address #41 .
Added a test for this.
Also fixed an annoying UI problem with the query form where hitting enter or tab would cause a dinging noise.
I ran tests on my computer and the only tests that failed were the MSSQL tests (which is expected because SQL Server is not installed on my computer).