fix(media): restore Media state on unserialize from Doctrine cache#88
Open
BriceFab wants to merge 1 commit intojolicode:mainfrom
Open
fix(media): restore Media state on unserialize from Doctrine cache#88BriceFab wants to merge 1 commit intojolicode:mainfrom
BriceFab wants to merge 1 commit intojolicode:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Media::__unserialize()so cachedMediainstances restore typed properties correctly[0 => path, 1 => library])Media::$resolverInitializerin bundle boot (same resolver used by Doctrine media types)Problem
When an entity containing
JoliCode\MediaBundle\Model\Mediais read from Doctrine second-level cache, unserialization may create dynamic properties ($0,$1) instead of restoring constructor-backed typed properties.This can leave
$pathuninitialized and later crash at runtime whengetPath()is accessed.Validation
tests/src/Model/MediaTest.phpfor:Fixes #87
cc @xavierlacot