Added trailing slash generates faulty canonical links

[thusslack]

This is more of a question, than an issue.

kirby-static-site-generator/class.php

Line 68 in 54a02f3

$baseUrl = rtrim($baseUrl, '/') . '/';

This line generates faulty canonical links in our setup.
Our static sites runs in a subfolder (e.g. https://domain.tld/static). When generating a static site given this base url, the canonical link of the homepage always has a trailing slash. Thats not totally wrong, but unwanted in our case.

Since kirby already does a great job with generating urls, what is this line needed for?

[jonathan-reisdorf]

Hello 👋 Thanks for reporting!
I added this change in 2019 as part of d4l-data4life/kirby3-static-site-generator#2 when fixing static site generation for single-language sites, but I don't exactly recall why I it seemed necessary back then. This should be solvable more elegantly respecting the original settings, but fixing it will require some testing since in _generatePage there's a lot of rewriting going on to match URLs rendered in different ways, especially also since things were primarily tested without protocol and domain in their base url, so e.g. only /static