Skip to content

Conversation

@dikshant182004
Copy link
Contributor

hii @asoplata ,i have update some of the docstrings of some funtions in hnn_core/viz.py under issue #993 ,if they looks good then we i will scale it up to every funtion docstring .If it needs any changes do tell me .

@dikshant182004
Copy link
Contributor Author

hi @asoplata ,can u plz check my pr ?

@dikshant182004
Copy link
Contributor Author

hi @asoplata looks like u are back .can u plz check this pr and tell me what i am doing wrong

@asoplata
Copy link
Collaborator

asoplata commented Mar 7, 2025

Hey Dikshant, please understand that we want to help as much as possible, but our response times can vary. Our developers have finite time and there is a lot of work to do on HNN with different priority levels, but we are working hard to assist everyone.

@asoplata
Copy link
Collaborator

Hello @dikshant182004 , please either rebase or merge your PR branch onto the newest version of upstream's master branch. There was a bug in our tests that was probably why the tests failed here, but it should be fixed now. Apologies for that. Once that is done I will review

@asoplata asoplata changed the title updated some docstrings [WIP] updated some docstrings Mar 14, 2025
@dikshant182004
Copy link
Contributor Author

okay @asoplata ,i will rebase the pr branch into the newest version of upstream's master branch

@dikshant182004
Copy link
Contributor Author

hi @asoplata ,i was induldge in something so i was not able to push a pr ,i just wanted to ask that can i open a new pr with new branch as i am facing some issue in pushing these changes from the following branch .

@asoplata
Copy link
Collaborator

Hey @dikshant182004 Please do not open a new PR. Please send me a zipped-copy of your local git repo in its entirety to my email address; I may be able to help you over a Zoom call this week.

@dikshant182004
Copy link
Contributor Author

hi @asoplata ,i have send u the zipped file ,plz have a look and tell me when we can schedule our zoom meeting .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants