[WIP]: Refactor cells_default.pyfor simplicity and incoming new models
#1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes disabling of the existing way to create this celltype (calling `pyramidal` which then calls `_cell_L5pyr`), and includes an example script to show that the results output the same.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @Chetank99
This branch and PR should be the main place where we perform our refactoring of
cells_default.py, in order to both better organize it, and, possibly, actually include Katharina's new celltypes. @Chetank99 and @katduecker are more than welcome to push commits directly to my branch for this PR, if desired (instead of having to do a PR on my personal fork to the branch).I've added a working example of changing the L5 Pyramidal cell's creation functions into a self-contained "child class" of
Cell, at the bottom ofcells_default.py. This includes an example script at the top-level directory to show that the results output the same. Just to make it unambiguous that the script is not using the oldpyramidalfunction of creating the L5 Pyramidal (or_cell_L5pyr), I have commented out some of its code.Note: this will NOT currently pass testing for a number of reasons, including removing some functions, and changing an object's type.