-
-
Notifications
You must be signed in to change notification settings - Fork 40
feat: add additional exit commands to client interface #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hey @gnzng thank you so much for contributing to the project 🙌 please, check my comments and suggestions when you have a chance to move forward! 🚀 |
Co-authored-by: Jonathan Gastón Löwenstern <jonigl@gmail.com>
Co-authored-by: Jonathan Gastón Löwenstern <jonigl@gmail.com>
hey @gnzng I have added 2 other suggestions. Also, I found two missing parts:
No rush buddy! And again thanks for your contributions and suggestions I appreciate that 💪 |
@jonigl thanks for the catch. It is implemented and tested: ![]() Please, let me know if it needs other changes. |
awesome @gnzng! 👏 Only remaining changes are these two suggestions: https://github.com/jonigl/mcp-client-for-ollama/pull/71/files#r2273572287 |
Co-authored-by: Jonathan Gastón Löwenstern <jonigl@gmail.com>
Co-authored-by: Jonathan Gastón Löwenstern <jonigl@gmail.com>
Commited both lints 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@gnzng PR has been merged. FYI, this exit command will be part of the next |
Hey @gnzng I have just released the |
Great client!
This PR is adding
bye
and/bye
, as it is theollama
default to exit theollama run
shell.