Skip to content

Conversation

gnzng
Copy link
Contributor

@gnzng gnzng commented Aug 12, 2025

Great client!

This PR is adding bye and /bye, as it is the ollama default to exit the ollama run shell.

@jonigl
Copy link
Owner

jonigl commented Aug 13, 2025

hey @gnzng thank you so much for contributing to the project 🙌 please, check my comments and suggestions when you have a chance to move forward! 🚀

gnzng and others added 3 commits August 13, 2025 06:24
Co-authored-by: Jonathan Gastón Löwenstern <jonigl@gmail.com>
Co-authored-by: Jonathan Gastón Löwenstern <jonigl@gmail.com>
@jonigl
Copy link
Owner

jonigl commented Aug 13, 2025

hey @gnzng I have added 2 other suggestions.

Also, I found two missing parts:

  1. Here you can add bye so this can be par of the autocomplete

    'quit': 'Exit the application',
    'exit': 'Exit the application'

  2. Here you can add bye so it can be part of the help message

    "• Type [bold]quit[/bold], [bold]q[/bold], [bold]exit[/bold], or [bold]Ctrl+D[/bold] to exit the client\n",

No rush buddy! And again thanks for your contributions and suggestions I appreciate that 💪

@gnzng
Copy link
Contributor Author

gnzng commented Aug 13, 2025

@jonigl thanks for the catch. It is implemented and tested:
image

image

Please, let me know if it needs other changes.

@jonigl
Copy link
Owner

jonigl commented Aug 13, 2025

gnzng and others added 2 commits August 13, 2025 10:07
Co-authored-by: Jonathan Gastón Löwenstern <jonigl@gmail.com>
Co-authored-by: Jonathan Gastón Löwenstern <jonigl@gmail.com>
@gnzng
Copy link
Contributor Author

gnzng commented Aug 13, 2025

Commited both lints 👍

Copy link
Owner

@jonigl jonigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonigl jonigl merged commit 5b02f58 into jonigl:main Aug 13, 2025
4 checks passed
@jonigl
Copy link
Owner

jonigl commented Aug 13, 2025

@gnzng PR has been merged. FYI, this exit command will be part of the next ollmcp release

@gnzng gnzng deleted the addbye branch August 13, 2025 20:46
@jonigl
Copy link
Owner

jonigl commented Aug 14, 2025

Hey @gnzng I have just released the ollmcp v0.18.0 🎉 Here you can see your first contribution! 🙌 https://github.com/jonigl/mcp-client-for-ollama/releases/tag/v0.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants