fix: move CORS config to utils and suppress warning on --version (#19)

- Move configure_cors function from api.py to utils.py to break circular import
- Add sys.argv check to suppress CORS warnings during --version command
- Call configure_cors during FastAPI app creation instead of lifespan

Author: jonigl

src/ollama_mcp_bridge/api.py

@@ -1,15 +1,13 @@
 """FastAPI application"""
-import os
 from typing import Dict, Any
 import httpx
 from fastapi import FastAPI, HTTPException, Body, status, Request
 from fastapi.responses import JSONResponse
-from fastapi.middleware.cors import CORSMiddleware
 from loguru import logger
 
 from .lifecycle import lifespan, get_proxy_service
 from .schemas import CHAT_EXAMPLE
-from .utils import check_for_updates
+from .utils import check_for_updates, configure_cors
 from . import __version__
 
 
@@ -21,24 +19,8 @@
     lifespan=lifespan
 )
 
-# Configure CORS
-cors_origins = os.getenv("CORS_ORIGINS", "*").split(",")
-cors_origins = [origin.strip() for origin in cors_origins]
-
-# Log CORS configuration
-if cors_origins == ["*"]:
-    logger.warning("CORS is configured to allow ALL origins (*). This is not recommended for production.")
-else:
-    logger.info(f"CORS configured to allow origins: {cors_origins}")
-
-app.add_middleware(
-    CORSMiddleware,
-    allow_origins=cors_origins,
-    allow_credentials=True,
-    allow_methods=["*"],
-    allow_headers=["*"],
-)
-
+# Configure CORS middleware
+configure_cors(app)
 
 @app.get("/health", summary="Health check", description="Check the health status of the MCP Proxy and Ollama server.")
 async def health():
@@ -74,6 +56,7 @@ async def chat(
         logger.error(f"/api/chat failed: {e}")
         raise HTTPException(status_code=500, detail=f"/api/chat failed: {str(e)}") from e
 
+
 @app.get("/version", summary="Version information", description="Get version information and check for updates.")
 async def version():
     """Version information endpoint."""
@@ -84,6 +67,7 @@ async def version():
         "latest_version": latest_version
     }
 
+
 @app.api_route("/{path_name:path}", methods=["GET", "POST", "PUT", "DELETE", "PATCH", "OPTIONS", "HEAD"],
                summary="Transparent proxy", description="Transparent proxy to any Ollama endpoint.",
                include_in_schema=False)

src/ollama_mcp_bridge/utils.py

@@ -7,6 +7,32 @@
 from typer import BadParameter
 from loguru import logger
 from packaging import version as pkg_version
+from fastapi.middleware.cors import CORSMiddleware
+import sys
+
+
+def configure_cors(app):
+    """Configure CORS middleware for the FastAPI app."""
+
+    cors_origins = os.getenv("CORS_ORIGINS", "*").split(",")
+    cors_origins = [origin.strip() for origin in cors_origins]
+
+    # Don't log CORS config if the user is checking the version
+    is_version_check = any('--version' in arg for arg in sys.argv)
+
+    if not is_version_check:
+        if cors_origins == ["*"]:
+            logger.warning("CORS is configured to allow ALL origins (*). This is not recommended for production.")
+        else:
+            logger.info(f"CORS configured to allow origins: {cors_origins}")
+
+    app.add_middleware(
+        CORSMiddleware,
+        allow_origins=cors_origins,
+        allow_credentials=True,
+        allow_methods=["*"],
+        allow_headers=["*"],
+    )
 
 
 def check_ollama_health(ollama_url: str, timeout: int = 3) -> bool: