Fix pool on testing (#2)

During testing the pool is injected to be able to rollback
the transaction on every test. If the asyncpg.Pool is injected
on construction (testing) it should not be closed by the
on_disconnect event from the asgi

Author: jordic

CHANGELOG.rst

@@ -1,3 +1,5 @@
-## 1.0.0
+- 1.0.1
+  Fix testing pool incorrectly disconnected
 
-- Initial release
+- 1.0.0
+  Initial release

fastapi_asyncpg/__init__.py

@@ -44,6 +44,7 @@ def __init__(
     async def on_connect(self):
         """handler called during initialitzation of asgi app, that connects to
         the db"""
+        # if the pool is comming from outside (tests), don't connect it
         if self._pool:
             self.app.state.pool = self._pool
             return
@@ -53,6 +54,10 @@ async def on_connect(self):
         self.app.state.pool = pool
 
     async def on_disconnect(self):
+        # if the pool is comming from outside, don't desconnect it
+        # someone else will do (usualy a pytest fixture)
+        if self._pool:
+            return
         await self.app.state.pool.close()
 
     def on_init(self, func):

setup.py

@@ -8,7 +8,7 @@
 
 setup(
     name="fastapi_asyncpg",
-    version="1.0.0",
+    version="1.0.1",
     url="https://github.com/jordic/fastapi_asyncpg",
     license="MIT",
     author="Jordi collell",

tests/test_db.py

@@ -116,7 +116,7 @@ async def test_pool_releases_connections(asgiapp):
         res = await client.post("/", json={"key": "test", "value": "val1"})
         assert res.status_code == 200
         tasks = []
-        for i in range(5):
+        for i in range(20):
             tasks.append(client.get("/test"))
 
         await asyncio.gather(*tasks)