This repository was archived by the owner on Apr 21, 2023. It is now read-only.
Augeas will fail if the section is missing #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a potential regression introduced in 6e049d4. If the `[shclustering]` is completely missing from the `server.conf`, this augeas rule will fail to create it. Even if it is not a practical regression for a Splunk deployment, it's a nice to make it complete for the benefit of anyone referring to this code in the future.
chutzimir
force-pushed
the
augeas-splunk-lens
branch
from
65af0af to
1405fb5
Compare
|
Thanks! Merged! Too bad we have no testcases for this. Looking around it seems rspec-puppet-augeas would be helpful to create one or two unit tests. I'm only subtly dropping this in the off-chance you happen to have some more time available to dig into this haha! |
We can continue the effort in #61 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential regression introduced in
6e049d4. If the
[shclustering]iscompletely missing from the
server.conf, this augeas rule will fail tocreate it.
Even if it is not a practical regression for a Splunk deployment, it's a
nice to make it complete for the benefit of anyone referring to this
code in the future.