avoid clamping if line height is still valid#32
Open
danielloeh wants to merge 1 commit intojosephschmitt:masterfrom
Open
avoid clamping if line height is still valid#32danielloeh wants to merge 1 commit intojosephschmitt:masterfrom
danielloeh wants to merge 1 commit intojosephschmitt:masterfrom
Conversation
…rger than the maximum
|
+1 this is a working fix |
|
This probably fixes issue #33 |
|
It doesn't look like this library is being maintained so here you go |
|
@timrnz Thanks! I actually ended op writing my own version. |
|
@laustdeleuran awesome! I've been meaning to re-write it into ES6/'15. Maybe I'll do it this weekend. |
|
@timrnz awesome - keep me posted on that. Still need to get into the ES6 game myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we used firefox (or any other browser without native clamping), the last line was always clamped: it cuts of the last letter and appends e.g. the "..." even if theres plenty of space in that line. This is because the condition checks if the current line height is greater or equal than the maximum allowed. So if the text is rendered in two lines (eg 2 x 10px) and the maximum allowed is the same, it still gets clamped. We removed the "or equal" from the condition so it only gets truncated if the rendered line height is too high and that works for us perfectly now.