Skip to content

Kill use of getBytes() which depends on platform encoding. #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Kill use of getBytes() which depends on platform encoding. #105

wants to merge 1 commit into from

Conversation

lhunath
Copy link
Contributor

@lhunath lhunath commented May 19, 2018 •
edited
Loading

Hash uses String.getBytes() even though we're passing in an Encoder. getBytes uses the current platform encoding, which is unpredictable. Replace it with usage of the Encoder.

@lhunath
Copy link
Contributor Author

lhunath commented May 20, 2018

This one failed with:

IOError: [Errno 28] No space left on device

Not sure what to do with that.

@joshjdevl
Copy link
Owner

Build has been restarted.

@lhunath
Copy link
Contributor Author

lhunath commented May 20, 2018

Looks like the real issue is HashTest failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lhunath @joshjdevl