Open
Conversation
Attach parsed pubsub responses to SubMsg requests so message data is delivered. Adds pubsub_message_response test and runs it in test harness.
Pause message queuing while subscriptions are pending to preserve confirmation ordering. Adds pubsub_subscription_order test and includes it in the test runner.
Handle pubsub message replies immediately and reset the parser to avoid response reuse. Adds pubsub_parser_reset test and runs it in the harness.
Convert unexpected null responses into DeliverRequestFail instead of crashing. Adds null_response_handling test and runs it in the harness.
Extract subscription counts from the response tail to avoid truncation. Adds pubsub_long_name test and runs it in the harness.
Return the error for forbidden commands in transactions without closing the client. Adds transaction_forbid test and runs it in the harness.
Avoid coercing MGET errors into nil when aggregating responses. Adds mget_wrong_type test and runs it in the harness.
Prevent MSETNX from being split across shards to preserve atomicity. Adds msetnx_atomicity test and runs it in the harness.
Reject EVAL/EVALSHA when keys map to different hash groups. Adds eval_cross_shard test and runs it in the harness.
Remove stray statements introduced during staging and normalize test runner order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a comprehensive test harness for Predixy and fixes numerous bugs discovered through testing, focusing on Redis parity, thread-safety, and parser edge cases.
Key improvements: