Use modern Buffer APIs (LinusU#11)

Fixes the LinusU#10 `DeprecationWarning: Buffer() is deprecated due to
security and usability issues` warning

Author: jozefizso

lib/create.js

@@ -30,7 +30,7 @@ var findVolume = function (startPath, startStat) {
 }
 
 var utf16be = function (str) {
-  var b = new Buffer(str, 'ucs2')
+  var b = Buffer.from(str, 'ucs2')
   for (var i = 0; i < b.length; i += 2) {
     var a = b[i]
     b[i] = b[i + 1]
@@ -72,7 +72,7 @@ module.exports = exports = function (targetPath, options) {
   };
 
   (function addType0 () {
-    var b = new Buffer(info.parent.name, 'utf8')
+    var b = Buffer.from(info.parent.name, 'utf8')
 
     info.extra.push({
       type: 0,
@@ -82,7 +82,7 @@ module.exports = exports = function (targetPath, options) {
   }());
 
   (function addType1 () {
-    var b = new Buffer(4)
+    var b = Buffer.alloc(4)
 
     b.writeUInt32BE(info.parent.id, 0)
 
@@ -95,7 +95,7 @@ module.exports = exports = function (targetPath, options) {
 
   (function addType14 () {
     var l = info.target.filename.length
-    var b = new Buffer(2 + (l * 2))
+    var b = Buffer.alloc(2 + (l * 2))
 
     b.writeUInt16BE(l, 0)
     utf16be(info.target.filename).copy(b, 2)
@@ -109,7 +109,7 @@ module.exports = exports = function (targetPath, options) {
 
   (function addType15 () {
     var l = info.volume.name.length
-    var b = new Buffer(2 + (l * 2))
+    var b = Buffer.alloc(2 + (l * 2))
 
     b.writeUInt16BE(l, 0)
     utf16be(info.volume.name).copy(b, 2)
@@ -125,7 +125,7 @@ module.exports = exports = function (targetPath, options) {
     var vl = volumePath.length
     assert.equal(targetPath.slice(0, vl), volumePath)
     var lp = targetPath.slice(vl)
-    var b = new Buffer(lp, 'utf8')
+    var b = Buffer.from(lp, 'utf8')
 
     info.extra.push({
       type: 18,
@@ -135,7 +135,7 @@ module.exports = exports = function (targetPath, options) {
   }());
 
   (function addType19 () {
-    var b = new Buffer(volumePath, 'utf8')
+    var b = Buffer.from(volumePath, 'utf8')
 
     info.extra.push({
       type: 19,

lib/encode.js

@@ -23,7 +23,7 @@ module.exports = exports = function (info) {
   }, 0)
   var trailerLength = 4
 
-  var buf = new Buffer(baseLength + extraLength + trailerLength)
+  var buf = Buffer.alloc(baseLength + extraLength + trailerLength)
 
   buf.writeUInt32BE(0, 0)
 

lib/is-alias.js

@@ -6,7 +6,7 @@ module.exports = function isAlias (path) {
   var fd = fs.openSync(path, 'r')
 
   try {
-    read = new Buffer(16)
+    read = Buffer.alloc(16)
     fs.readSync(fd, read, 0, 16, 0)
   } finally {
     fs.closeSync(fd)

package.json

@@ -7,7 +7,8 @@
   "contributors": [
     "Linus Unnebäck <linus@folkdatorn.se>",
     "Davide Liessi <davide.liessi@gmail.com>",
-    "Joshua Warner <joshuawarner32@gmail.com>"
+    "Joshua Warner <joshuawarner32@gmail.com>",
+    "Jozef Izso <jozef.izso@@gmail.com>"
   ],
   "devDependencies": {
     "fs-temp": "^1.1.1",

test/basics.js

@@ -7,7 +7,7 @@ var path = require('path')
 var temp = require('fs-temp')
 var assert = require('assert')
 
-var rawData = new Buffer(
+var rawData = Buffer.from(
   'AAAAAAEqAAIAAApUZXN0IFRpdGxlAAAAAAAAAAAAAAAAAAAAAADO615USCsA' +
   'BQAAABMMVGVzdEJrZy50aWZmAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA' +
   'AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAFM7rXlgAAAAAAAAAAP////8A' +
@@ -72,8 +72,8 @@ describe('isAlias', function () {
   var aliasFile, garbageFile
 
   before(function () {
-    aliasFile = temp.writeFileSync(new Buffer('626f6f6b000000006d61726b00000000', 'hex'))
-    garbageFile = temp.writeFileSync(new Buffer('Hello my name is Linus!'))
+    aliasFile = temp.writeFileSync(Buffer.from('626f6f6b000000006d61726b00000000', 'hex'))
+    garbageFile = temp.writeFileSync(Buffer.from('Hello my name is Linus!'))
   })
 
   after(function () {