This repository was archived by the owner on May 26, 2020. It is now read-only.
setting JWT_PAYLOAD_GET_USER_ID_HANDLER ignored#380
Open
SPKorhonen wants to merge 3 commits intojpadilla:masterfrom
Open
setting JWT_PAYLOAD_GET_USER_ID_HANDLER ignored#380SPKorhonen wants to merge 3 commits intojpadilla:masterfrom
SPKorhonen wants to merge 3 commits intojpadilla:masterfrom
Conversation
User_id is read directly from payload leading to problems when using custom useri_id
Contributor
|
Can you add a test, please? |
Author
|
Tests added to exercise the code paths within jwt_get_secret_key |
|
Could you please merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User_id is read directly from payload leading to problems when using custom encoding on user_id field. Trivial fix: use api_settings.JWT_PAYLOAD_GET_USER_ID_HANDLER instead of payload.get('user_id').
Fixes issue #379