-
Notifications
You must be signed in to change notification settings - Fork 161
Depend only on Foundation Essentials #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b0fd085
to
dfb2075
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
==========================================
- Coverage 91.31% 90.94% -0.37%
==========================================
Files 21 21
Lines 1797 1790 -7
==========================================
- Hits 1641 1628 -13
- Misses 156 162 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hmmm. Seems some cleanup is due around the use of NSNull. It strikes me as an odd choice compared to |
PR supplying NSNull where it is missing: #454 |
Replace CharacterSet with Set<Character>
Replace NSRegularExpression with Regex
Provide an NSNull definition where FoundationEssentials is imported.
@t089 This effort has lead to the necessity of replacing NumberFormatter, which I think is a really terrible decision for all the platforms that do have NumberFormatter. I've engaged this thought process so far as an abstract exercise – the smallest footprint is the best footprint. But in the face of this challenge, I'll like to ask a more practical question. What kind of platform would actually benefit from diminishing the dependency to merely FoundationEssentials? Microcontrollers? Kernel modules? What was on your mind when you initially opened the issue? What is on your mind now? |
That is unfortunate indeed. I think the original observation is valid for any non-Darwin platform:
For a fundamental library such as yams it feels wrong to incur this binary size cost. |
Addresses #358
N.B. @t089