Skip to content

jquery: Update Twitter to x ,add mastodon and replace FontAwesome font with SVG icons#489

Open
HermitShamiko wants to merge 12 commits intojquery:mainfrom
HermitShamiko:Fontawesome-SVG
Open

jquery: Update Twitter to x ,add mastodon and replace FontAwesome font with SVG icons#489
HermitShamiko wants to merge 12 commits intojquery:mainfrom
HermitShamiko:Fontawesome-SVG

Conversation

@HermitShamiko
Copy link
Contributor

@HermitShamiko HermitShamiko commented Feb 23, 2026

@timmywil @mgol

  1. Twitter was renamed to X in March 2023. This pull aims to update the Twitter account (including icons and links) of the jQuery website to X.
  2. Since jQuery uses Font Awesome 3.0.2, which does not include the x-twitter icon and is only supported in the latest 7.x version, I attempted to upgrade jQuery's Font Awesome from 3.0.2 to 7.2.0, and update it from Font Awesome's woff format to Font Awesome's svg format. After upgrading to version 7.2.0, I found that some icons had been removed or their Unicode encoding had changed, so I updated them accordingly.For information on updating Font Awesome to SVG icons, see reference Replace FontAwesome font with SVG icons #455.
  3. Based on suggestion jquery: Update Twitter to x #488, jQuery's mastodon has been added to the footer's footer-site-links.

The updated icon style is as follows:
footer(new):
GG}7G60%@GC5KUEJDOV~N$6

footer(old):
1

learn(new):
D4I9A Q%H$ ~F5`$C9E%IWA

learn(old):
2

@timmywil
Copy link
Member

Thank you! I noticed in your footer screenshot that the chat icon seems to be cut off a bit at the top. I wonder if the SVG is not actually square. Could you look into that?

@HermitShamiko
Copy link
Contributor Author

Thank you! I noticed in your footer screenshot that the chat icon seems to be cut off a bit at the top. I wonder if the SVG is not actually square. Could you look into that?

Yes, I found some issues with the viewBox section of comments.svg in version 7.2.0 that caused it to display incompletely. I have manually fixed the malfunctioning viewBox.
It can now be displayed correctly.
6HPYV~0LPVXSNB 6WVFQ A5

Fixed the issue where content was affected by line-height.
@HermitShamiko
Copy link
Contributor Author

Two new changes:

  1. Directly using the content url() to include an SVG would be affected by other line-height properties; this has been changed to use background instead.

new:
1AF8L107VC$GSMMA UPT4L1

old:
4RFS`HQIA)9~MN{ A`T5E

  1. Optimized the issue of the GitHub icon in the Open Source Content section of learn.jquery.com not being prominent enough; it has been adjusted to have the same effect as the footer.

new:
C@A%2NMJ$HB_BNT PW{ 8RD

old:
T9)OSMQ2 O% )8N3KOFGS4X

Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@HermitShamiko
Copy link
Contributor Author

HermitShamiko commented Feb 24, 2026

Thank you! LGTM

Sorry, I just discovered three icons with minor issues; their missing parts were so small that I didn't notice them. I've already fixed them.
Now all SVG icons can display their full size.

old:
old

new:
new

@HermitShamiko
Copy link
Contributor Author

HermitShamiko commented Feb 25, 2026

I discovered an old problem and solved it this time: The icon-link next to the heading in the h tag used on website page was not aligned with the heading itself.

new:
new

old:
old

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants