fix(canonical-title-map): add use case for enumNames#8
Open
jmfrancois wants to merge 2 commits intojson-schema-form:developmentfrom
jmfrancois:jmfrancois/enumNames
Open
fix(canonical-title-map): add use case for enumNames#8jmfrancois wants to merge 2 commits intojson-schema-form:developmentfrom jmfrancois:jmfrancois/enumNames
jmfrancois wants to merge 2 commits intojson-schema-form:developmentfrom
jmfrancois:jmfrancois/enumNames
Conversation
scottux
reviewed
Jan 10, 2018
| } | ||
| return canonical; | ||
| } else if (originalEnum) { | ||
| const canonical = []; |
There was a problem hiding this comment.
This definition of canonical doesn't seem to be used. I think it is safe to remove it.
scottux
reviewed
Aug 13, 2018
| if (typeof titleMap[index] === 'string') { | ||
| return { | ||
| name: titleMap[index], | ||
| value, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support case for enumNames.
Spec: json-schema-org/json-schema-spec#57
We have some schemas with the following shape:
This raise exception with the current implementation because we have an array of value for the titleMap;
Checklist
@json-schema-form/angular-schema-form-lead