Skip to content

Order decorator fixes #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2-1-stable
Choose a base branch
from
Open

Order decorator fixes #100

wants to merge 1 commit into from

Conversation

nefarianblack
Copy link

'current_item' in order decorator is now an instance of variant instead of truthy/falsy values.

Issue: #99.

@nefarianblack
class:Order add_variant methods 'current_item' is now an instance of …
8ac1368 
…'variant' instead of truthy/falsy values. Issue: jsqu99#99.
@nefarianblack nefarianblack changed the title class:Order add_variant methods 'current_item' is now an instance of 'va... Order decorator fixes May 26, 2014
@nefarianblack nefarianblack mentioned this pull request May 26, 2014
Open
hammadxcm
hammadxcm reviewed Aug 29, 2025
View reviewed changes
Copy link

@hammadxcm hammadxcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we follow adding test coverage on changes? just curious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@hammadxcm hammadxcm hammadxcm left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nefarianblack @hammadxcm