Skip to content

fix: prevent single node timeout from blocking all other updates#2679

Closed
bobelev wants to merge 1 commit intojuanfont:mainfrom
bobelev:bblv/next
Closed

fix: prevent single node timeout from blocking all other updates#2679
bobelev wants to merge 1 commit intojuanfont:mainfrom
bobelev:bblv/next

Conversation

@bobelev
Copy link
Copy Markdown
Contributor

@bobelev bobelev commented Jul 9, 2025

One blocked/slow node in sendAll() was causing early return, skipping
all remaining nodes in iteration. Change return to continue to ensure
all healthy nodes receive updates even when some fail.

@bobelev bobelev requested review from juanfont and kradalby as code owners July 9, 2025 06:06
@ghost
Copy link
Copy Markdown

ghost commented Jul 9, 2025

Pull Request Revisions

RevisionDescription
r2No changes since last revision
r1
Changed return to continue statementIn the sendAll method, replaced return with continue to allow processing of remaining channels after a cancelled send

☑️ AI review skipped for r2
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at team@review.ai.

One blocked/slow node in sendAll() was causing early return, skipping
all remaining nodes in iteration. Change return to continue to ensure
all healthy nodes receive updates even when some fail.
@kradalby
Copy link
Copy Markdown
Collaborator

kradalby commented Jul 9, 2025

All of these things are currently being rewritten, so this code will go away soon.

@kradalby
Copy link
Copy Markdown
Collaborator

closing as the code is gone

@kradalby kradalby closed this Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants