fix: prevent single node timeout from blocking all other updates#2679
Closed
bobelev wants to merge 1 commit intojuanfont:mainfrom
Closed
fix: prevent single node timeout from blocking all other updates#2679bobelev wants to merge 1 commit intojuanfont:mainfrom
bobelev wants to merge 1 commit intojuanfont:mainfrom
Conversation
Pull Request Revisions
☑️ AI review skipped for r2 HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at team@review.ai. |
ghost
approved these changes
Jul 9, 2025
One blocked/slow node in sendAll() was causing early return, skipping all remaining nodes in iteration. Change return to continue to ensure all healthy nodes receive updates even when some fail.
Collaborator
|
All of these things are currently being rewritten, so this code will go away soon. |
Collaborator
|
closing as the code is gone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One blocked/slow node in sendAll() was causing early return, skipping
all remaining nodes in iteration. Change return to continue to ensure
all healthy nodes receive updates even when some fail.