-
Notifications
You must be signed in to change notification settings - Fork 12
Inland flow #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Inland flow #79
Conversation
TRUE | ||
Some rivers end at inland basin flow points. This inland basin flow is used to increase soil moisture at these locations. For this to work JULES rivers_standalone needs | ||
to be run as a separate executable and the inland basin flow needs to be passed into this land surface component via OASIS using :nml:mem:`OASIS_RIVERS::send_fields`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested rewording as it has to be relevant for the UM.
Some rivers end at inland basin flow points. This inland basin flow is used to increase soil moisture at these locations for water conservation purposes. This is only available for coupled models i.e. UM or LFRic. When coupled to LFRic, the soil moisture flux correction applied by this switch must be calculated by the Rivers-standalone component (:nml:mem:JULES_MODEL_ENVIRONMENT::lsm_id
= 3) and passed to LFRic via OASIS using :nml:mem:OASIS_RIVERS::send_fields
= inland_outflow.
.. nml:namelist:: JULES_LAND_FRAC | ||
Land fraction is the fraction of each gridbox that is land. Currently, JULES considers any gridbox with land fraction > 0 to be 100% land, and all others to be 100% sea (or sea-ice). Land fraction data can be used to select only land points from the full input grid (see below). | ||
Land fraction is the fraction of each gridbox that is land. By default, JULES considers any gridbox with land fraction > 0 to be 100% land, and all others to be 100% sea (or sea-ice). To keep land fractions as fractions then set l_use_land_fraction to True. Land fraction data can be used to select only land points from the full input grid (see below). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Land fractions are only used by TRIP in Rivers-standalone to determine coastal endorheic basins. So the docs should reflect this. How about:
Land fraction is the fraction of each gridbox that is land. By default, JULES considers any gridbox with land fraction > 0 to be 100% land, and all others to be 100% sea (or sea-ice). Rivers-standalone (TRIP) when coupled to LFRic needs to be able to determine coastal endorheic basins. In this case, :nml:mem:l_use_land_fraction
, allows the land fractions to be kept. Land fraction data can be used to select only land points from the full input grid (see below).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a few suggested changes to ensure that inland basin flow description is valid for all modes of running JULES.
FALSE | ||
No inland basin flow. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should highlight that this is only used in coupled models e.g.
.. note::
Inland basin flow is only available to coupled models i.e. UM & LFRic via OASIS-Rivers.
:type: logical | ||
:default: F | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently there is no link between l_inland and l_use_land_fraction in the code as they are done in two steps. l_inland cannot be used unless coupled, however this is a standalone namelist so it is a bit confusing I think. How about first having an explanation of when the switch is used.
Land fractions are used to determine coastal endorheic basins to calculate the inland basin flow diagnostic inland_outflow_rp
or :nml:mem:OASIS_RIVERS::send_fields
= inland_outflow.
FALSE | ||
Land fractions are not used and the land fraction field is set to either 1.0 (any land) or 0.0. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. note:: This is only available in Rivers-standalone (TRIP) to calculate inland outflow fields.
:default: F | ||
|
||
TRUE | ||
Supply land fractions (as fractions) to both the main grid and the rivers grid (if grids are compatible). This is needed for water conservation when using inland basin flow (l_inland = True). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supply land fractions (as fractions) to both the main grid and the rivers grid. This requires both grids and land-sea mask to be the same.
Add the l_inland switch, the l_use_land_fraction switch and add inland_outflow to the list of possible send_fields.
Associated with JULES ticket #1528 = https://code.metoffice.gov.uk/trac/jules/ticket/1528