chore: Migrate to web 1.0.0 #1147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navaronbracke
commented
Aug 13, 2024
| environment: | ||
| sdk: ">=3.3.0 <4.0.0" | ||
| flutter: ">=3.19.0" | ||
| sdk: ">=3.4.0 <4.0.0" |
There was a problem hiding this comment.
Per the changelog for web:1.0.0 it requires Dart 3.4.0
navaronbracke
commented
Aug 13, 2024
| }); | ||
| }); | ||
| </script> | ||
| <script src="flutter_bootstrap.js" async></script> |
There was a problem hiding this comment.
Flutter 3.22 uses new bootstrapping logic for web
|
Unrelated, but we're hitting the CanvasKit module error when running this on the latest stable. The fix for that bug is going to be cherry picked, so I'll revisit the web example later. (I'll have to bump the new requirement to Flutter 3.24 for the Impeller migration in a subsequent release anyway) |
|
@navaronbracke Hi! Could you please publish a relase? |
joaopedro735
pushed a commit
to joaopedro735/mobile_scanner
that referenced
this pull request
Aug 22, 2024
chore: Migrate to web 1.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1141